We do not remove HTML tags from the description of a RSS feed item anymore, because:
This didn't worked for all feeds, because we first removed the tags and then unescape the data, which didn't make sense
We render the HTML to Makrdown in the frontend so that the description can contain HTML tags and is still properly rendered and in some case better rendered then before
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/129
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 2/2/2024
**Status:** ✅ Merged
**Merged:** 2/2/2024
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `rss-do-not-remove-html-tags`
---
### 📝 Commits (1)
- [`5c864d8`](https://github.com/feeddeck/feeddeck/commit/5c864d862f5ad84d5c3be4d0cf026d3632fa37da) [rss] Do Not Remove HTML Tags
### 📊 Changes
**2 files changed** (+5 additions, -5 deletions)
<details>
<summary>View changed files</summary>
📝 `supabase/functions/_shared/feed/rss.ts` (+2 -2)
📝 `supabase/functions/_shared/feed/rss_test.ts` (+3 -3)
</details>
### 📄 Description
We do not remove HTML tags from the description of a RSS feed item anymore, because:
- This didn't worked for all feeds, because we first removed the tags and then unescape the data, which didn't make sense
- We render the HTML to Makrdown in the frontend so that the description can contain HTML tags and is still properly rendered and in some case better rendered then before
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/129
Author: @ricoberger
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/2/2024
Merged by: @ricoberger
Base:
main← Head:rss-do-not-remove-html-tags📝 Commits (1)
5c864d8[rss] Do Not Remove HTML Tags📊 Changes
2 files changed (+5 additions, -5 deletions)
View changed files
📝
supabase/functions/_shared/feed/rss.ts(+2 -2)📝
supabase/functions/_shared/feed/rss_test.ts(+3 -3)📄 Description
We do not remove HTML tags from the description of a RSS feed item anymore, because:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.