github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-10 07:32:05 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #55] [MERGED] [github] Fix Notification Links for PRs #59

New Issue
Closed
opened 2025-10-31 16:56:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:56:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/55
Author: @ricoberger
Created: 10/29/2023
Status: ✅ Merged
Merged: 10/29/2023
Merged by: @ricoberger

Base: main ← Head: github-fix-notification-link-for-prs

📝 Commits (1)

  • d9c5728 [github] Fix Notification Links for PRs

📊 Changes

2 files changed (+20 additions, -7 deletions)

View changed files

📝 supabase/functions/_shared/feed/github.ts (+20 -6)
📝 supabase/functions/_shared/feed/x.ts (+0 -1)

📄 Description

If a notification was related to a pull request the link we added to the item didn't work. This should now be fixed, so that when a user clicks on the item he is redirected to the correct pull request which is associated with the item.

This commit also removes an unnecessary "console.log" statement.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/55 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `github-fix-notification-link-for-prs` --- ### 📝 Commits (1) - [`d9c5728`](https://github.com/feeddeck/feeddeck/commit/d9c5728e69ae065367b90bdce366c0dabafe977b) [github] Fix Notification Links for PRs ### 📊 Changes **2 files changed** (+20 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `supabase/functions/_shared/feed/github.ts` (+20 -6) 📝 `supabase/functions/_shared/feed/x.ts` (+0 -1) </details> ### 📄 Description If a notification was related to a pull request the link we added to the item didn't work. This should now be fixed, so that when a user clicks on the item he is redirected to the correct pull request which is associated with the item. This commit also removes an unnecessary "console.log" statement. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#59
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?