github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #52] [MERGED] [rss] Improve Rendering of Items #56

New Issue
Closed
opened 2025-10-31 16:56:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:56:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/52
Author: @ricoberger
Created: 10/27/2023
Status: ✅ Merged
Merged: 10/28/2023
Merged by: @ricoberger

Base: main ← Head: rss-improve-rendering-of-items

📝 Commits (1)

  • 0d597ff [rss] Improve Rendering of Items

📊 Changes

8 files changed (+47 additions, -19 deletions)

View changed files

📝 app/lib/widgets/item/details/item_details_rss.dart (+23 -5)
📝 app/lib/widgets/item/details/utils/item_description.dart (+2 -2)
📝 app/lib/widgets/item/details/utils/item_subtitle.dart (+4 -3)
📝 app/lib/widgets/item/preview/item_preview_rss.dart (+1 -1)
📝 app/lib/widgets/item/preview/utils/item_description.dart (+2 -2)
📝 app/pubspec.lock (+1 -1)
📝 app/pubspec.yaml (+1 -0)
📝 supabase/functions/_shared/feed/rss.ts (+13 -5)

📄 Description

The items of an RSS feed are now rendered better, to achieve this we did the following changes:

  • Remove leading and trailing whitespaces from the item description which should be rendered.
  • Check if the media file of an item is an SVG image. If this is the case we will not add it to the "media" field in the database, because currently the CachedNetworkImage widget can not render SVGs. If we want to render them, we run into serious performance issue so we skip them completly.
  • Always assume that the content of an RSS feed contains HTML and render them as plain text in the preview and as markdown in the details. Since we also render images from the description now, we check if the "item.media" image should be rendered. If the description contains an image we do not render our own image. If the description doesn't contain a image we render it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/52 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/27/2023 **Status:** ✅ Merged **Merged:** 10/28/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `rss-improve-rendering-of-items` --- ### 📝 Commits (1) - [`0d597ff`](https://github.com/feeddeck/feeddeck/commit/0d597ff81ab7f9face359e1e3e2169b24de284b1) [rss] Improve Rendering of Items ### 📊 Changes **8 files changed** (+47 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/item/details/item_details_rss.dart` (+23 -5) 📝 `app/lib/widgets/item/details/utils/item_description.dart` (+2 -2) 📝 `app/lib/widgets/item/details/utils/item_subtitle.dart` (+4 -3) 📝 `app/lib/widgets/item/preview/item_preview_rss.dart` (+1 -1) 📝 `app/lib/widgets/item/preview/utils/item_description.dart` (+2 -2) 📝 `app/pubspec.lock` (+1 -1) 📝 `app/pubspec.yaml` (+1 -0) 📝 `supabase/functions/_shared/feed/rss.ts` (+13 -5) </details> ### 📄 Description The items of an RSS feed are now rendered better, to achieve this we did the following changes: - Remove leading and trailing whitespaces from the item description which should be rendered. - Check if the media file of an item is an SVG image. If this is the case we will not add it to the "media" field in the database, because currently the CachedNetworkImage widget can not render SVGs. If we want to render them, we run into serious performance issue so we skip them completly. - Always assume that the content of an RSS feed contains HTML and render them as plain text in the preview and as markdown in the details. Since we also render images from the description now, we check if the "item.media" image should be rendered. If the description contains an image we do not render our own image. If the description doesn't contain a image we render it. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#56
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?