[PR #46] [MERGED] [core] Fix Number of Loaded Items per Fetch #51

New Issue

GiteaMirror · 2025-10-31T16:56:22-05:00

GiteaMirror commented

2025-10-31 16:56:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/46
Author: @ricoberger
Created: 10/22/2023
Status: ✅ Merged
Merged: 10/22/2023
Merged by: @ricoberger

Base: main ← Head: core-fix-number-of-loaded-items

📝 Commits (1)

2eee9ea [core] Fix Number of Loaded Items per Fetch

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 app/lib/repositories/items_repository.dart (+1 -1)
📝 app/lib/widgets/column/header/column_layout_header.dart (+1 -1)

📄 Description

We always loaded 51 items per fetch instead of 50 items, because we used a range of 0 to 50 which includes the item at position 0 and at position
50. This is now fixed by adjusting the range to 0 to 49, so that exactly 50 items are loaded per fetch request.

This commit also improves the number of loaded items shown in the column header. If the status of the ItemsRepository is "loaded" we add a small "+" symbol behind the number to indicat that there are more items, which could be loaded. If the last page was already fetched (status == "loadedLast") then the "+" symbol isn't shown.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/46 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-number-of-loaded-items` --- ### 📝 Commits (1) - [`2eee9ea`](https://github.com/feeddeck/feeddeck/commit/2eee9ea02b50b28a4cbe84a1acfdd80d8249f068) [core] Fix Number of Loaded Items per Fetch ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/repositories/items_repository.dart` (+1 -1) 📝 `app/lib/widgets/column/header/column_layout_header.dart` (+1 -1) </details> ### 📄 Description We always loaded 51 items per fetch instead of 50 items, because we used a range of 0 to 50 which includes the item at position 0 and at position 50. This is now fixed by adjusting the range to 0 to 49, so that exactly 50 items are loaded per fetch request. This commit also improves the number of loaded items shown in the column header. If the status of the ItemsRepository is "loaded" we add a small "+" symbol behind the number to indicat that there are more items, which could be loaded. If the last page was already fetched (status == "loadedLast") then the "+" symbol isn't shown.   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-10-31 16:56:22 -05:00

GiteaMirror closed this issue

2025-10-31 16:56:22 -05:00

GiteaMirror referenced this issue

2025-10-31 16:56:26 -05:00

[PR #51] [MERGED] [mastodon] Add Support for Videos #55

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/feeddeck#51