[PR #45] [MERGED] [core] Fix ItemsRepository Status #50

Closed
opened 2025-10-31 16:56:21 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/45
Author: @ricoberger
Created: 10/22/2023
Status: Merged
Merged: 10/22/2023
Merged by: @ricoberger

Base: mainHead: core-fix-items-repository-status


📝 Commits (1)

  • fe5c0a2 [core] Fix ItemsRepository Status

📊 Changes

1 file changed (+23 additions, -10 deletions)

View changed files

📝 app/lib/repositories/items_repository.dart (+23 -10)

📄 Description

This commit fixes the status of an ItemsRepository when the repository
is initalized from the ItemsRepositoryStore instead of the "_getItems"
function.

After the repository was initialized from the ItemsRepositoryStore we
always set the status of the repository to "loaded", also when we had
less then 50 items. Because of that we also always displayed the "Load
More" button. This is now fixed by adding the status of the repository
to the ItemsRepositoryStore, so that the "Load More" button is only
shown when there are more items to load.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/45 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-items-repository-status` --- ### 📝 Commits (1) - [`fe5c0a2`](https://github.com/feeddeck/feeddeck/commit/fe5c0a2eebe834cdc187a0c11c9dfd927a0ba712) [core] Fix ItemsRepository Status ### 📊 Changes **1 file changed** (+23 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/repositories/items_repository.dart` (+23 -10) </details> ### 📄 Description This commit fixes the status of an ItemsRepository when the repository is initalized from the ItemsRepositoryStore instead of the "_getItems" function. After the repository was initialized from the ItemsRepositoryStore we always set the status of the repository to "loaded", also when we had less then 50 items. Because of that we also always displayed the "Load More" button. This is now fixed by adding the status of the repository to the ItemsRepositoryStore, so that the "Load More" button is only shown when there are more items to load. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:21 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#50