This commit adds two improvements to the ItemVideoPlayer widget. These improvements are:
The padding for the widget is now defined within the widget, so that is must not be defined in the parent widget. With this change the widget follows the styling of our other widgets like ItemMedia.
On iOS the quality selection had a large bottom padding, this is now fixed, by using a Wrap widget instead of a ListView like we are using in the other modal bottom sheets which are showing some actions.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/95
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 12/2/2023
**Status:** ✅ Merged
**Merged:** 12/2/2023
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `core-improve-item-video-player-widget`
---
### 📝 Commits (1)
- [`25c6bb4`](https://github.com/feeddeck/feeddeck/commit/25c6bb4441c132f184111020c5d0bcdeaabe687c) [core] Improve `ItemVideoPlayer` Widget
### 📊 Changes
**3 files changed** (+92 additions, -87 deletions)
<details>
<summary>View changed files</summary>
📝 `app/lib/widgets/item/details/item_details_lemmy.dart` (+2 -8)
📝 `app/lib/widgets/item/details/utils/item_videos.dart` (+87 -70)
📝 `app/lib/widgets/item/details/utils/item_youtube/item_youtube_video_native.dart` (+3 -9)
</details>
### 📄 Description
This commit adds two improvements to the `ItemVideoPlayer` widget. These improvements are:
1. The padding for the widget is now defined within the widget, so that is must not be defined in the parent widget. With this change the widget follows the styling of our other widgets like `ItemMedia`.
2. On iOS the quality selection had a large bottom padding, this is now fixed, by using a `Wrap` widget instead of a `ListView` like we are using in the other modal bottom sheets which are showing some actions.
<!--
Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the
the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz".
If you add a breaking change within your PR you should add ":warning:" to the title,
e.g. ":warning: [core] My breaking change"
-->
<!--
Description of what have been changed. Please also reference an issue, when available.
-->
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/95
Author: @ricoberger
Created: 12/2/2023
Status: ✅ Merged
Merged: 12/2/2023
Merged by: @ricoberger
Base:
main← Head:core-improve-item-video-player-widget📝 Commits (1)
25c6bb4[core] ImproveItemVideoPlayerWidget📊 Changes
3 files changed (+92 additions, -87 deletions)
View changed files
📝
app/lib/widgets/item/details/item_details_lemmy.dart(+2 -8)📝
app/lib/widgets/item/details/utils/item_videos.dart(+87 -70)📝
app/lib/widgets/item/details/utils/item_youtube/item_youtube_video_native.dart(+3 -9)📄 Description
This commit adds two improvements to the
ItemVideoPlayerwidget. These improvements are:ItemMedia.Wrapwidget instead of aListViewlike we are using in the other modal bottom sheets which are showing some actions.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.