github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 15:12:10 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #42] [MERGED] [podcast] Fix Audio Player for Windows and Linux #47

New Issue
Closed
opened 2025-10-31 16:56:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:56:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/42
Author: @ricoberger
Created: 10/20/2023
Status: ✅ Merged
Merged: 10/20/2023
Merged by: @ricoberger

Base: main ← Head: podcast-fix-audio-player-for-windows-and-linux

📝 Commits (1)

  • 50fcb21 [podcast] Fix Audio Player for Windows and Linux

📊 Changes

7 files changed (+83 additions, -34 deletions)

View changed files

📝 .github/workflows/continuous-delivery.yaml (+3 -0)
📝 app/linux/flutter/generated_plugin_registrant.cc (+4 -0)
📝 app/linux/flutter/generated_plugins.cmake (+2 -0)
📝 app/pubspec.lock (+68 -28)
📝 app/pubspec.yaml (+1 -2)
📝 app/windows/flutter/generated_plugin_registrant.cc (+3 -3)
📝 app/windows/flutter/generated_plugins.cmake (+2 -1)

📄 Description

Instead of using the "just_audio_windows" and "just_audio_mpv" packages for Windows and Linux, we are now using "just_audio_media_kit", so that the audio player is working reliable on these platforms.

Note: We have to adjust the Flatpak, to include the dependencies which are required on Linux.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/42 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/20/2023 **Status:** ✅ Merged **Merged:** 10/20/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `podcast-fix-audio-player-for-windows-and-linux` --- ### 📝 Commits (1) - [`50fcb21`](https://github.com/feeddeck/feeddeck/commit/50fcb2101ca23abdba70b34530d6ccfd8e43c841) [podcast] Fix Audio Player for Windows and Linux ### 📊 Changes **7 files changed** (+83 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/continuous-delivery.yaml` (+3 -0) 📝 `app/linux/flutter/generated_plugin_registrant.cc` (+4 -0) 📝 `app/linux/flutter/generated_plugins.cmake` (+2 -0) 📝 `app/pubspec.lock` (+68 -28) 📝 `app/pubspec.yaml` (+1 -2) 📝 `app/windows/flutter/generated_plugin_registrant.cc` (+3 -3) 📝 `app/windows/flutter/generated_plugins.cmake` (+2 -1) </details> ### 📄 Description Instead of using the "just_audio_windows" and "just_audio_mpv" packages for Windows and Linux, we are now using "just_audio_media_kit", so that the audio player is working reliable on these platforms. Note: We have to adjust the Flatpak, to include the dependencies which are required on Linux. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#47
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?