mirror of
https://github.com/feeddeck/feeddeck.git
synced 2026-03-22 21:09:51 -05:00
[PR #136] [MERGED] [nitter] Add Support for Piped Videos #418
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/136
Author: @ricoberger
Created: 2/10/2024
Status: ✅ Merged
Merged: 2/11/2024
Merged by: @ricoberger
Base:
main← Head:nitter-add-support-for-piped-videos📝 Commits (1)
a4a240e[nitter] Add Support for Piped Videos📊 Changes
9 files changed (+355 additions, -35 deletions)
View changed files
📝
app/lib/widgets/item/details/item_details_nitter.dart(+63 -20)➕
app/lib/widgets/item/details/utils/item_piped/item_piped_video.dart(+20 -0)➕
app/lib/widgets/item/details/utils/item_piped/item_piped_video_native.dart(+125 -0)➕
app/lib/widgets/item/details/utils/item_piped/item_piped_video_stub.dart(+6 -0)➕
app/lib/widgets/item/details/utils/item_piped/item_piped_video_web.dart(+90 -0)📝
app/lib/widgets/item/details/utils/item_videos.dart(+32 -14)📝
app/lib/widgets/item/details/utils/item_youtube/item_youtube_video_native.dart(+2 -1)📝
app/pubspec.lock(+16 -0)📝
app/pubspec.yaml(+1 -0)📄 Description
The Nitter source now supports playing Piped Videos directly within the app. For this we are checking if the Nitter post contains a piped.video url and if this is the case we are using the newly added
ItemPipedVideowidget to render the video player, to allow users to directly play the video within the app.To support Piped videos we had to create a new
ItemPipedVideowidget, which is very similar to theItemYoutubeVideowidget. This means on the web version of FeedDeck we show the Video via an iframe and on the other platforms via ourItemVideoPlayerwidget. The main difference between Piped and YouTube widget is the different client we use to fetch the video urls. Besides the Piped API returns two different stream one for the video and one for the audio, so that we had to add an additionalaudioparamter to theItemVideoPlayerwidget, which allows us to specify an additional audio source for a video.NOTE: We had to add support for Piped, because Nitter automatically converts the YouTube urls to the corresponding Piped urls.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.