github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #34] [MERGED] [core] Rework Profile Edge Function #40

New Issue
Closed
opened 2025-10-31 16:56:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:56:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/34
Author: @ricoberger
Created: 10/14/2023
Status: ✅ Merged
Merged: 10/14/2023
Merged by: @ricoberger

Base: main ← Head: core-rework-profile-edge-function

📝 Commits (1)

  • c13b623 [core] Rework Profile Edge Function

📊 Changes

7 files changed (+292 additions, -21 deletions)

View changed files

📝 .github/workflows/continuous-delivery.yaml (+4 -2)
📝 CONTRIBUTING.md (+2 -1)
📝 app/lib/repositories/profile_repository.dart (+22 -16)
📝 app/lib/widgets/settings/accounts/settings_accounts_github.dart (+2 -2)
📝 supabase/functions/profile-v1/index.ts (+3 -0)
➕ supabase/functions/profile-v2/github.ts (+83 -0)
➕ supabase/functions/profile-v2/index.ts (+176 -0)

📄 Description

This commit introduces a new "profile-v2" edge function and deprecates the "profile-v1" edge function. We decided to provide a new edge function for all profile related operation to improve the handling of the different operation the edge function is responsible for.

The main differences to the "profile-v1" functions are:

  • Pass the operation id within the request url instead of the body of the request.
  • Move the operations for accounts (e.g. GitHub) to seperate files, to improve the readability of the function.
  • Do not require the "sourceType" anymore, instead we are using the operation id and request method to determine the operation which should be executed
  • The request body is now only used for the data of the corresponding account and not for any other information like the operation id and source information.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/34 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/14/2023 **Status:** ✅ Merged **Merged:** 10/14/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-rework-profile-edge-function` --- ### 📝 Commits (1) - [`c13b623`](https://github.com/feeddeck/feeddeck/commit/c13b6239d115a58a102519048577fb53772f541a) [core] Rework Profile Edge Function ### 📊 Changes **7 files changed** (+292 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/continuous-delivery.yaml` (+4 -2) 📝 `CONTRIBUTING.md` (+2 -1) 📝 `app/lib/repositories/profile_repository.dart` (+22 -16) 📝 `app/lib/widgets/settings/accounts/settings_accounts_github.dart` (+2 -2) 📝 `supabase/functions/profile-v1/index.ts` (+3 -0) ➕ `supabase/functions/profile-v2/github.ts` (+83 -0) ➕ `supabase/functions/profile-v2/index.ts` (+176 -0) </details> ### 📄 Description This commit introduces a new "profile-v2" edge function and deprecates the "profile-v1" edge function. We decided to provide a new edge function for all profile related operation to improve the handling of the different operation the edge function is responsible for. The main differences to the "profile-v1" functions are: - Pass the operation id within the request url instead of the body of the request. - Move the operations for accounts (e.g. GitHub) to seperate files, to improve the readability of the function. - Do not require the "sourceType" anymore, instead we are using the operation id and request method to determine the operation which should be executed - The request body is now only used for the data of the corresponding account and not for any other information like the operation id and source information. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#40
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?