mirror of
https://github.com/feeddeck/feeddeck.git
synced 2026-03-09 07:02:01 -05:00
[PR #26] [CLOSED] [core] Fix Scrolling in List of Sources in Columns #32
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/26
Author: @ricoberger
Created: 10/12/2023
Status: ❌ Closed
Base:
main← Head:core-fix-scrolling-in-list-of-sources-in-columns📝 Commits (1)
866c62d[core] Fix Scrolling in List of Sources in Columns📊 Changes
2 files changed (+68 additions, -22 deletions)
View changed files
📝
app/ios/Podfile.lock(+1 -1)📝
app/lib/widgets/column/list/column_layout_list.dart(+67 -21)📄 Description
Above the items of a column we display a list of sources, which can be used by a user to only show items for a selected source. If a column contains a lot of sources the list is vertical scrollable.
This vertical scrolling is not working on Linux, Windows and the Web and only works on touch screens and on the magic trackpad for macOS, because at the same time a user can also scroll horizontally.
To fix this we decided to move the list of sources out of the list of items on macOS, Linux, Windows and on the web for large screens. This way the vertical scroll can not conflict with the horizontal scroll. This also means that the sources are always displayed on these platforms.
For iOS, Android and on the web for small screens we do not changed the behaviour. Since we assume that a user always has a touch screen for the scrolling. We can also not change is because we do not have that much screen space on these platforms and have to safe the space for the list of items.
Fixes #25
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.