[PR #26] [CLOSED] [core] Fix Scrolling in List of Sources in Columns #32

Closed
opened 2025-10-31 16:56:00 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/26
Author: @ricoberger
Created: 10/12/2023
Status: Closed

Base: mainHead: core-fix-scrolling-in-list-of-sources-in-columns


📝 Commits (1)

  • 866c62d [core] Fix Scrolling in List of Sources in Columns

📊 Changes

2 files changed (+68 additions, -22 deletions)

View changed files

📝 app/ios/Podfile.lock (+1 -1)
📝 app/lib/widgets/column/list/column_layout_list.dart (+67 -21)

📄 Description

Above the items of a column we display a list of sources, which can be used by a user to only show items for a selected source. If a column contains a lot of sources the list is vertical scrollable.

This vertical scrolling is not working on Linux, Windows and the Web and only works on touch screens and on the magic trackpad for macOS, because at the same time a user can also scroll horizontally.

To fix this we decided to move the list of sources out of the list of items on macOS, Linux, Windows and on the web for large screens. This way the vertical scroll can not conflict with the horizontal scroll. This also means that the sources are always displayed on these platforms.

For iOS, Android and on the web for small screens we do not changed the behaviour. Since we assume that a user always has a touch screen for the scrolling. We can also not change is because we do not have that much screen space on these platforms and have to safe the space for the list of items.

Fixes #25


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/26 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/12/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `core-fix-scrolling-in-list-of-sources-in-columns` --- ### 📝 Commits (1) - [`866c62d`](https://github.com/feeddeck/feeddeck/commit/866c62d052ec27d23985d00b34519c5e8523a3bc) [core] Fix Scrolling in List of Sources in Columns ### 📊 Changes **2 files changed** (+68 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `app/ios/Podfile.lock` (+1 -1) 📝 `app/lib/widgets/column/list/column_layout_list.dart` (+67 -21) </details> ### 📄 Description Above the items of a column we display a list of sources, which can be used by a user to only show items for a selected source. If a column contains a lot of sources the list is vertical scrollable. This vertical scrolling is not working on Linux, Windows and the Web and only works on touch screens and on the magic trackpad for macOS, because at the same time a user can also scroll horizontally. To fix this we decided to move the list of sources out of the list of items on macOS, Linux, Windows and on the web for large screens. This way the vertical scroll can not conflict with the horizontal scroll. This also means that the sources are always displayed on these platforms. For iOS, Android and on the web for small screens we do not changed the behaviour. Since we assume that a user always has a touch screen for the scrolling. We can also not change is because we do not have that much screen space on these platforms and have to safe the space for the list of items. Fixes #25 <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:00 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#32