github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #20] [MERGED] [youtube] Add Missing URL in isYoutubeUrl Function #27

New Issue
Closed
opened 2025-10-31 16:55:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:55:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/20
Author: @ricoberger
Created: 10/7/2023
Status: ✅ Merged
Merged: 10/7/2023
Merged by: @ricoberger

Base: main ← Head: youtube-add-missing-url

📝 Commits (1)

  • e80a931 [youtube] Add Missing URL in isYoutubeUrl Function

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 supabase/functions/_shared/feed/youtube.ts (+2 -1)

📄 Description

In the "isYoutubeUrl" function we are checking if the provided url is related to YouTube. For that we checked if the url starts with "https://www.youtube.com/" or "https://m.youtube.com/", but we also have to check if the url starts with "https://youtube.com/" which is used when a users shares a link to a channel via the YouTube app.

In this commit we add the missing "https://youtube.com/" option to the "isYoutubeUrl" function.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/20 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/7/2023 **Status:** ✅ Merged **Merged:** 10/7/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `youtube-add-missing-url` --- ### 📝 Commits (1) - [`e80a931`](https://github.com/feeddeck/feeddeck/commit/e80a9319bbab1259207bf8973c314d9f6b895b46) [youtube] Add Missing URL in isYoutubeUrl Function ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `supabase/functions/_shared/feed/youtube.ts` (+2 -1) </details> ### 📄 Description In the "isYoutubeUrl" function we are checking if the provided url is related to YouTube. For that we checked if the url starts with "https://www.youtube.com/" or "https://m.youtube.com/", but we also have to check if the url starts with "https://youtube.com/" which is used when a users shares a link to a channel via the YouTube app. In this commit we add the missing "https://youtube.com/" option to the "isYoutubeUrl" function. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:55:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#27
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?