[PR #247] [MERGED] Rework Edge Functions #237

Closed
opened 2025-10-31 17:00:12 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/247
Author: @ricoberger
Created: 4/21/2025
Status: Merged
Merged: 4/23/2025
Merged by: @ricoberger

Base: mainHead: format-functions-code


📝 Commits (1)

📊 Changes

68 files changed (+2718 additions, -2801 deletions)

View changed files

📝 .github/workflows/continuous-delivery.yaml (+22 -22)
📝 .github/workflows/continuous-integration.yaml (+9 -2)
📝 CONTRIBUTING.md (+13 -13)
📝 supabase/functions/_cmd/Dockerfile (+3 -3)
📝 supabase/functions/_cmd/scheduler/scheduler.ts (+2 -2)
📝 supabase/functions/_cmd/tools/apple-secret-key.ts (+16 -13)
📝 supabase/functions/_cmd/tools/tools.ts (+22 -27)
📝 supabase/functions/_cmd/worker/worker.ts (+2 -2)
📝 supabase/functions/_shared/feed/feed.ts (+105 -63)
📝 supabase/functions/_shared/feed/fourchan.ts (+103 -102)
📝 supabase/functions/_shared/feed/fourchan_test.ts (+48 -54)
📝 supabase/functions/_shared/feed/github.ts (+251 -269)
📝 supabase/functions/_shared/feed/googlenews.ts (+33 -28)
📝 supabase/functions/_shared/feed/googlenews_test.ts (+110 -117)
📝 supabase/functions/_shared/feed/lemmy.ts (+125 -122)
📝 supabase/functions/_shared/feed/lemmy_test.ts (+225 -222)
📝 supabase/functions/_shared/feed/mastodon.ts (+46 -46)
📝 supabase/functions/_shared/feed/mastodon_test.ts (+123 -123)
📝 supabase/functions/_shared/feed/medium.ts (+56 -52)
📝 supabase/functions/_shared/feed/medium_test.ts (+140 -144)

...and 48 more files

📄 Description

Instead of using an import_map.json file to define the versions for
dependencies, they are now defined directly within the import. Since the
import_map.json file should not be used anymore and instead a
deno.json file per function should be used, we decided to define them
directly with the code. The overhead compared to a deno.json file per
function shouldn't be that large and it makes using functions in a
self-hosted setup easier.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/247 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 4/21/2025 **Status:** ✅ Merged **Merged:** 4/23/2025 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `format-functions-code` --- ### 📝 Commits (1) - [`7679d25`](https://github.com/feeddeck/feeddeck/commit/7679d252e5b083d92b808b14ef9dde769d166a11) Rework Edge Functions ### 📊 Changes **68 files changed** (+2718 additions, -2801 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/continuous-delivery.yaml` (+22 -22) 📝 `.github/workflows/continuous-integration.yaml` (+9 -2) 📝 `CONTRIBUTING.md` (+13 -13) 📝 `supabase/functions/_cmd/Dockerfile` (+3 -3) 📝 `supabase/functions/_cmd/scheduler/scheduler.ts` (+2 -2) 📝 `supabase/functions/_cmd/tools/apple-secret-key.ts` (+16 -13) 📝 `supabase/functions/_cmd/tools/tools.ts` (+22 -27) 📝 `supabase/functions/_cmd/worker/worker.ts` (+2 -2) 📝 `supabase/functions/_shared/feed/feed.ts` (+105 -63) 📝 `supabase/functions/_shared/feed/fourchan.ts` (+103 -102) 📝 `supabase/functions/_shared/feed/fourchan_test.ts` (+48 -54) 📝 `supabase/functions/_shared/feed/github.ts` (+251 -269) 📝 `supabase/functions/_shared/feed/googlenews.ts` (+33 -28) 📝 `supabase/functions/_shared/feed/googlenews_test.ts` (+110 -117) 📝 `supabase/functions/_shared/feed/lemmy.ts` (+125 -122) 📝 `supabase/functions/_shared/feed/lemmy_test.ts` (+225 -222) 📝 `supabase/functions/_shared/feed/mastodon.ts` (+46 -46) 📝 `supabase/functions/_shared/feed/mastodon_test.ts` (+123 -123) 📝 `supabase/functions/_shared/feed/medium.ts` (+56 -52) 📝 `supabase/functions/_shared/feed/medium_test.ts` (+140 -144) _...and 48 more files_ </details> ### 📄 Description Instead of using an `import_map.json` file to define the versions for dependencies, they are now defined directly within the import. Since the `import_map.json` file should not be used anymore and instead a `deno.json` file per function should be used, we decided to define them directly with the code. The overhead compared to a `deno.json` file per function shouldn't be that large and it makes using functions in a self-hosted setup easier. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 17:00:12 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#237