github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-08 22:52:02 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #243] [MERGED] Prefer content over description for Item Description #233

New Issue
Closed
opened 2025-10-31 17:00:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 17:00:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/243
Author: @ricoberger
Created: 4/19/2025
Status: ✅ Merged
Merged: 4/19/2025
Merged by: @ricoberger

Base: main ← Head: prefer-content-field-over-description-field

📝 Commits (1)

  • e0038f8 Prefer content over description for Item Description

📊 Changes

2 files changed (+533 additions, -580 deletions)

View changed files

📝 supabase/functions/_shared/feed/rss.ts (+96 -76)
📝 supabase/functions/_shared/feed/rss_test.ts (+437 -504)

📄 Description

Until now, we always checked the description field of an item first to
get our description value. If the description field is present we
directly used it and never checked the content field.

Now we are checking the content field first and afterwards the
description field. This way by default the content field is used as
our description. This should be more common to get the full article text
when both fields are present in an RSS feed.

When both fields are present and the description field is longer then
the content field, we will still prefer the description field.

Closes #226

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/243 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 4/19/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `prefer-content-field-over-description-field` --- ### 📝 Commits (1) - [`e0038f8`](https://github.com/feeddeck/feeddeck/commit/e0038f8a4933e1d7237f6ae042398484b6b90a74) Prefer `content` over `description` for Item Description ### 📊 Changes **2 files changed** (+533 additions, -580 deletions) <details> <summary>View changed files</summary> 📝 `supabase/functions/_shared/feed/rss.ts` (+96 -76) 📝 `supabase/functions/_shared/feed/rss_test.ts` (+437 -504) </details> ### 📄 Description Until now, we always checked the `description` field of an item first to get our description value. If the `description` field is present we directly used it and never checked the `content` field. Now we are checking the `content` field first and afterwards the `description` field. This way by default the `content` field is used as our description. This should be more common to get the full article text when both fields are present in an RSS feed. When both fields are present and the `description` field is longer then the `content` field, we will still prefer the `description` field. Closes #226 <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 17:00:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?