github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #186] [MERGED] [core] Fix Warnings and Regenerate Splash Screens #184

New Issue
Closed
opened 2025-10-31 16:59:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:59:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/186
Author: @ricoberger
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @ricoberger

Base: main ← Head: core-fix-warnings-and-regenerate-splash-screens

📝 Commits (1)

  • f6479d0 [core] Fix Warnings and Regenerate Splash Screens

📊 Changes

28 files changed (+162 additions, -106 deletions)

View changed files

📝 app/android/app/src/main/res/drawable-hdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-hdpi/splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-mdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-mdpi/splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-night-hdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-night-mdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-night-xhdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-night-xxhdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-xhdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-xhdpi/splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-xxhdpi/android12splash.png (+0 -0)
📝 app/android/app/src/main/res/drawable-xxhdpi/splash.png (+0 -0)
📝 app/android/app/src/main/res/values-night/styles.xml (+4 -0)
📝 app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png (+0 -0)
📝 app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@2x.png (+0 -0)
📝 app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@3x.png (+0 -0)
📝 app/ios/Runner/Info.plist (+65 -65)
📝 app/web/index.html (+69 -35)
📝 app/web/splash/img/dark-1x.png (+0 -0)
📝 app/web/splash/img/dark-2x.png (+0 -0)

...and 8 more files

📄 Description

This commit fixes the following warnings for the web build:

Warning: In index.html:38: Local variable for "serviceWorkerVersion" is deprecated. Use "{{flutter_service_worker_version}}" template token instead.
Warning: In index.html:60: "FlutterLoader.loadEntrypoint" is deprecated. Use "FlutterLoader.load" instead.

To re-add the slash screen we alsow run the
flutter pub run flutter_native_splash:create command again, which also updated the splash screens for iOS and Android.

Last but not least this commit also fixes the following warnings for the Windows build:

windows/runner/flutter_window.cpp does not ensure the show window callback is called, updating.
windows/flutter/CMakeLists.txt does not use FLUTTER_TARGET_PLATFORM, updating.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/186 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-warnings-and-regenerate-splash-screens` --- ### 📝 Commits (1) - [`f6479d0`](https://github.com/feeddeck/feeddeck/commit/f6479d0ea2ef6332626dff0d48d788a48b6033c2) [core] Fix Warnings and Regenerate Splash Screens ### 📊 Changes **28 files changed** (+162 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `app/android/app/src/main/res/drawable-hdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-hdpi/splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-mdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-mdpi/splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-night-hdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-night-mdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-night-xhdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-night-xxhdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-xhdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-xhdpi/splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-xxhdpi/android12splash.png` (+0 -0) 📝 `app/android/app/src/main/res/drawable-xxhdpi/splash.png` (+0 -0) 📝 `app/android/app/src/main/res/values-night/styles.xml` (+4 -0) 📝 `app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png` (+0 -0) 📝 `app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@2x.png` (+0 -0) 📝 `app/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage@3x.png` (+0 -0) 📝 `app/ios/Runner/Info.plist` (+65 -65) 📝 `app/web/index.html` (+69 -35) 📝 `app/web/splash/img/dark-1x.png` (+0 -0) 📝 `app/web/splash/img/dark-2x.png` (+0 -0) _...and 8 more files_ </details> ### 📄 Description This commit fixes the following warnings for the web build: ``` Warning: In index.html:38: Local variable for "serviceWorkerVersion" is deprecated. Use "{{flutter_service_worker_version}}" template token instead. Warning: In index.html:60: "FlutterLoader.loadEntrypoint" is deprecated. Use "FlutterLoader.load" instead. ``` To re-add the slash screen we alsow run the `flutter pub run flutter_native_splash:create` command again, which also updated the splash screens for iOS and Android. Last but not least this commit also fixes the following warnings for the Windows build: ``` windows/runner/flutter_window.cpp does not ensure the show window callback is called, updating. windows/flutter/CMakeLists.txt does not use FLUTTER_TARGET_PLATFORM, updating. ``` <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:59:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?