github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #185] [MERGED] [core] Fix Web Build #183

New Issue
Closed
opened 2025-10-31 16:59:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:59:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/185
Author: @ricoberger
Created: 8/6/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @ricoberger

Base: main ← Head: core-fix-web-build

📝 Commits (1)

📊 Changes

6 files changed (+46 additions, -5 deletions)

View changed files

📝 .github/workflows/continuous-delivery.yaml (+6 -3)
📝 app/lib/main.dart (+4 -2)
➕ app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init.dart (+11 -0)
➕ app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_native.dart (+12 -0)
➕ app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_stub.dart (+5 -0)
➕ app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_web.dart (+8 -0)

📄 Description

Fix web build be initializing JustAudioMediaKit only on Linux and Windows where it is really used. The corresponding issue for the broken web build can be found here https://github.com/Pato05/just_audio_media_kit/issues/15.

To test the web build on every PR to avoid such issues, the CI/CD pipeline for the web build is now also run on every PR. On PRs we skip the upload to Cloudflare for the web build.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/185 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 8/6/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-web-build` --- ### 📝 Commits (1) - [`bdd054b`](https://github.com/feeddeck/feeddeck/commit/bdd054ba3b1478acc73419ddd5874b6dd1be8744) [core] Fix Web Build ### 📊 Changes **6 files changed** (+46 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/continuous-delivery.yaml` (+6 -3) 📝 `app/lib/main.dart` (+4 -2) ➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init.dart` (+11 -0) ➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_native.dart` (+12 -0) ➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_stub.dart` (+5 -0) ➕ `app/lib/widgets/item/details/utils/item_audio_palyer/item_audio_player_init/item_audio_player_init_web.dart` (+8 -0) </details> ### 📄 Description Fix web build be initializing `JustAudioMediaKit` only on Linux and Windows where it is really used. The corresponding issue for the broken web build can be found here https://github.com/Pato05/just_audio_media_kit/issues/15. To test the web build on every PR to avoid such issues, the CI/CD pipeline for the web build is now also run on every PR. On PRs we skip the upload to Cloudflare for the web build. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:59:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#183
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?