github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-22 12:46:47 -05:00
Code Issues 23 Packages Projects Releases 8 Wiki Activity

[PR #179] [CLOSED] Bump ws, engine.io, socket.io-adapter and engine.io-client in /supabase/email-templates #177

New Issue
Closed
opened 2025-10-31 16:58:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:58:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/179
Author: @dependabot[bot]
Created: 7/27/2024
Status: ❌ Closed

Base: main ← Head: dependabot/npm_and_yarn/supabase/email-templates/multi-d143a95b26

📝 Commits (1)

  • 9d23697 Bump ws, engine.io, socket.io-adapter and engine.io-client

📊 Changes

1 file changed (+502 additions, -5113 deletions)

View changed files

📝 supabase/email-templates/package-lock.json (+502 -5113)

📄 Description

Bumps ws, engine.io, socket.io-adapter and engine.io-client. These dependencies needed to be updated together.
Updates ws from 8.11.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;


for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;


for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';

if (++count === 2000) break;

}




}


headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';


const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});


request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates engine.io from 6.5.4 to 6.5.5

Release notes

Sourced from engine.io's releases.

6.5.5

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Bug Fixes

Links

Changelog

Sourced from engine.io's changelog.

6.5.5 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Bug Fixes

Dependencies

Commits

Updates socket.io-adapter from 2.5.4 to 2.5.5

Changelog

Sourced from socket.io-adapter's changelog.

2.5.5 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Commits

Updates engine.io-client from 6.5.3 to 6.5.4

Release notes

Sourced from engine.io-client's releases.

6.5.4

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Links

Changelog

Sourced from engine.io-client's changelog.

6.5.4 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Dependencies

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/179 **Author:** [@dependabot[bot]](https://github.com/apps/dependabot) **Created:** 7/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dependabot/npm_and_yarn/supabase/email-templates/multi-d143a95b26` --- ### 📝 Commits (1) - [`9d23697`](https://github.com/feeddeck/feeddeck/commit/9d23697f68cf72497873fe834d6fe91d37ecea16) Bump ws, engine.io, socket.io-adapter and engine.io-client ### 📊 Changes **1 file changed** (+502 additions, -5113 deletions) <details> <summary>View changed files</summary> 📝 `supabase/email-templates/package-lock.json` (+502 -5113) </details> ### 📄 Description Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/engine.io), [socket.io-adapter](https://github.com/socketio/socket.io-adapter) and [engine.io-client](https://github.com/socketio/engine.io-client). These dependencies needed to be updated together. Updates `ws` from 8.11.0 to 8.17.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p> <blockquote> <h2>8.17.1</h2> <h1>Bug fixes</h1> <ul> <li>Fixed a DoS vulnerability (<a href="https://redirect.github.com/websockets/ws/issues/2231">#2231</a>).</li> </ul> <p>A request with a number of headers exceeding the[<code>server.maxHeadersCount</code>][] threshold could be used to crash a ws server.</p> <pre lang="js"><code>const http = require('http'); const WebSocket = require('ws'); <p>const wss = new WebSocket.Server({ port: 0 }, function () { const chars = &quot;!#$%&amp;'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~&quot;.split(''); const headers = {}; let count = 0;</p> <p>for (let i = 0; i &lt; chars.length; i++) { if (count === 2000) break;</p> <pre><code>for (let j = 0; j &amp;lt; chars.length; j++) { const key = chars[i] + chars[j]; headers[key] = 'x'; if (++count === 2000) break; } </code></pre> <p>}</p> <p>headers.Connection = 'Upgrade'; headers.Upgrade = 'websocket'; headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ=='; headers['Sec-WebSocket-Version'] = '13';</p> <p>const request = http.request({ headers: headers, host: '127.0.0.1', port: wss.address().port });</p> <p>request.end(); }); </code></pre></p> <p>The vulnerability was reported by <a href="https://github.com/rrlapointe">Ryan LaPointe</a> in <a href="https://redirect.github.com/websockets/ws/issues/2230">websockets/ws#2230</a>.</p> <p>In vulnerable versions of ws, the issue can be mitigated in the following ways:</p> <ol> <li>Reduce the maximum allowed length of the request headers using the [<code>--max-http-header-size=size</code>][] and/or the [<code>maxHeaderSize</code>][] options so that no more headers than the <code>server.maxHeadersCount</code> limit can be sent.</li> </ol> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/websockets/ws/commit/3c56601092872f7d7566989f0e379271afd0e4a1"><code>3c56601</code></a> [dist] 8.17.1</li> <li><a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c"><code>e55e510</code></a> [security] Fix crash when the Upgrade header cannot be read (<a href="https://redirect.github.com/websockets/ws/issues/2231">#2231</a>)</li> <li><a href="https://github.com/websockets/ws/commit/6a00029edd924499f892aed8003cef1fa724cfe5"><code>6a00029</code></a> [test] Increase code coverage</li> <li><a href="https://github.com/websockets/ws/commit/ddfe4a804d79e7788ab136290e609f91cf68423f"><code>ddfe4a8</code></a> [perf] Reduce the amount of <code>crypto.randomFillSync()</code> calls</li> <li><a href="https://github.com/websockets/ws/commit/b73b11828d166e9692a9bffe9c01a7e93bab04a8"><code>b73b118</code></a> [dist] 8.17.0</li> <li><a href="https://github.com/websockets/ws/commit/29694a5905fa703e86667928e6bacac397469471"><code>29694a5</code></a> [test] Use the <code>highWaterMark</code> variable</li> <li><a href="https://github.com/websockets/ws/commit/934c9d6b938b93c045cb13e5f7c19c27a8dd925a"><code>934c9d6</code></a> [ci] Test on node 22</li> <li><a href="https://github.com/websockets/ws/commit/1817bac06e1204bfb578b8b3f4bafd0fa09623d0"><code>1817bac</code></a> [ci] Do not test on node 21</li> <li><a href="https://github.com/websockets/ws/commit/96c9b3deddf56cacb2d756aaa918071e03cdbc42"><code>96c9b3d</code></a> [major] Flip the default value of <code>allowSynchronousEvents</code> (<a href="https://redirect.github.com/websockets/ws/issues/2221">#2221</a>)</li> <li><a href="https://github.com/websockets/ws/commit/e5f32c7e1e6d3d19cd4a1fdec84890e154db30c1"><code>e5f32c7</code></a> [fix] Emit at most one event per event loop iteration (<a href="https://redirect.github.com/websockets/ws/issues/2218">#2218</a>)</li> <li>Additional commits viewable in <a href="https://github.com/websockets/ws/compare/8.11.0...8.17.1">compare view</a></li> </ul> </details> <br /> Updates `engine.io` from 6.5.4 to 6.5.5 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/engine.io/releases">engine.io's releases</a>.</em></p> <blockquote> <h2>6.5.5</h2> <p>This release contains a bump of the <code>ws</code> dependency, which includes an important <a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c">security fix</a>.</p> <p>Advisory: <a href="https://github.com/advisories/GHSA-3h5v-q93c-6h6q">https://github.com/advisories/GHSA-3h5v-q93c-6h6q</a></p> <h3>Bug Fixes</h3> <ul> <li><strong>types:</strong> make socket.request writable (<a href="https://redirect.github.com/socketio/engine.io/issues/697">#697</a>) (<a href="https://github.com/socketio/engine.io/commit/0efa04b5841816d18b0c6ebf7c5f592f8382978a">0efa04b</a>)</li> </ul> <h4>Links</h4> <ul> <li>Diff: <a href="https://github.com/socketio/engine.io/compare/6.5.4...6.5.5">https://github.com/socketio/engine.io/compare/6.5.4...6.5.5</a></li> <li>Client release: -</li> <li><a href="https://github.com/websockets/ws/releases/tag/8.17.1"><code>ws@~8.17.1</code></a> (<a href="https://github.com/websockets/ws/compare/8.11.0...8.17.1">diff</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/socketio/engine.io/blob/6.5.5/CHANGELOG.md">engine.io's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/socketio/engine.io/compare/6.5.4...6.5.5">6.5.5</a> (2024-06-18)</h2> <p>This release contains a bump of the <code>ws</code> dependency, which includes an important <a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c">security fix</a>.</p> <p>Advisory: <a href="https://github.com/advisories/GHSA-3h5v-q93c-6h6q">https://github.com/advisories/GHSA-3h5v-q93c-6h6q</a></p> <h3>Bug Fixes</h3> <ul> <li><strong>types:</strong> make socket.request writable (<a href="https://redirect.github.com/socketio/engine.io/issues/697">#697</a>) (<a href="https://github.com/socketio/engine.io/commit/0efa04b5841816d18b0c6ebf7c5f592f8382978a">0efa04b</a>)</li> </ul> <h3>Dependencies</h3> <ul> <li><a href="https://github.com/websockets/ws/releases/tag/8.17.1"><code>ws@~8.17.1</code></a> (<a href="https://github.com/websockets/ws/compare/8.11.0...8.17.1">diff</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/socketio/engine.io/commit/0cb977ab69134c4d040a2135d429c12724d52ae1"><code>0cb977a</code></a> chore(release): 6.5.5</li> <li><a href="https://github.com/socketio/engine.io/commit/adaa2079c4198b5f51e61d61aa68893db9247cc0"><code>adaa207</code></a> chore(deps): bump ws from 8.11.0 to 8.17.1 (<a href="https://redirect.github.com/socketio/engine.io/issues/702">#702</a>)</li> <li><a href="https://github.com/socketio/engine.io/commit/0efa04b5841816d18b0c6ebf7c5f592f8382978a"><code>0efa04b</code></a> fix(types): make socket.request writable (<a href="https://redirect.github.com/socketio/engine.io/issues/697">#697</a>)</li> <li>See full diff in <a href="https://github.com/socketio/engine.io/compare/6.5.4...6.5.5">compare view</a></li> </ul> </details> <br /> Updates `socket.io-adapter` from 2.5.4 to 2.5.5 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io-adapter/blob/2.5.5/CHANGELOG.md">socket.io-adapter's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/socketio/socket.io-adapter/compare/2.5.4...2.5.5">2.5.5</a> (2024-06-18)</h2> <p>This release contains a bump of the <code>ws</code> dependency, which includes an important <a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c">security fix</a>.</p> <p>Advisory: <a href="https://github.com/advisories/GHSA-3h5v-q93c-6h6q">https://github.com/advisories/GHSA-3h5v-q93c-6h6q</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/socketio/socket.io-adapter/commit/05a190a9dbf40226a1f8c0d21c0f7dc3718a297c"><code>05a190a</code></a> chore(release): 6.5.5</li> <li><a href="https://github.com/socketio/socket.io-adapter/commit/93fe19019e1c0b82a41a15bd86acbac10634c60b"><code>93fe190</code></a> chore(deps): bump ws from 8.11.0 to 8.17.1 (<a href="https://redirect.github.com/socketio/socket.io-adapter/issues/93">#93</a>)</li> <li>See full diff in <a href="https://github.com/socketio/socket.io-adapter/compare/2.5.4...2.5.5">compare view</a></li> </ul> </details> <br /> Updates `engine.io-client` from 6.5.3 to 6.5.4 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/engine.io-client/releases">engine.io-client's releases</a>.</em></p> <blockquote> <h2>6.5.4</h2> <p>This release contains a bump of the <code>ws</code> dependency, which includes an important <a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c">security fix</a>.</p> <p>Advisory: <a href="https://github.com/advisories/GHSA-3h5v-q93c-6h6q">https://github.com/advisories/GHSA-3h5v-q93c-6h6q</a></p> <h4>Links</h4> <ul> <li>Diff: <a href="https://github.com/socketio/engine.io-client/compare/6.5.3...6.5.4">https://github.com/socketio/engine.io-client/compare/6.5.3...6.5.4</a></li> <li>Server release: -</li> <li><a href="https://github.com/websockets/ws/releases/tag/8.17.1"><code>ws@~8.17.1</code></a> (<a href="https://github.com/websockets/ws/compare/8.11.0...8.17.1">diff</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/socketio/engine.io-client/blob/6.5.4/CHANGELOG.md">engine.io-client's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/socketio/engine.io-client/compare/6.5.3...6.5.4">6.5.4</a> (2024-06-18)</h2> <p>This release contains a bump of the <code>ws</code> dependency, which includes an important <a href="https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c">security fix</a>.</p> <p>Advisory: <a href="https://github.com/advisories/GHSA-3h5v-q93c-6h6q">https://github.com/advisories/GHSA-3h5v-q93c-6h6q</a></p> <h3>Dependencies</h3> <ul> <li><a href="https://github.com/websockets/ws/releases/tag/8.17.1"><code>ws@~8.17.1</code></a> (<a href="https://github.com/websockets/ws/compare/8.11.0...8.17.1">diff</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/socketio/engine.io-client/commit/454940dc990367caa5610632de6e36ec51926eeb"><code>454940d</code></a> chore(release): 6.5.4</li> <li><a href="https://github.com/socketio/engine.io-client/commit/0eb956b5c0e55bfd4e217d3e327ad06634bfac39"><code>0eb956b</code></a> chore: bump ws to version 8.17.1</li> <li>See full diff in <a href="https://github.com/socketio/engine.io-client/compare/6.5.3...6.5.4">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/feeddeck/feeddeck/network/alerts). </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:58:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?