github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #137] [MERGED] [landing] Add Feature Images for Mobile Screens #138

New Issue
Closed
opened 2025-10-31 16:58:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:58:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/137
Author: @ricoberger
Created: 2/11/2024
Status: ✅ Merged
Merged: 2/11/2024
Merged by: @ricoberger

Base: main ← Head: landing-add-feature-images-for-mobile

📝 Commits (1)

  • aa795e6 [landing] Add Feature Images for Mobile Screens

📊 Changes

26 files changed (+126 additions, -70 deletions)

View changed files

📝 landing/app/download/page.tsx (+4 -2)
📝 landing/app/get-started/desktop/page.tsx (+4 -2)
📝 landing/app/get-started/mobile/page.tsx (+4 -2)
📝 landing/app/page.tsx (+51 -12)
📝 landing/app/pricing/page.tsx (+4 -2)
📝 landing/app/privacy-policy/page.tsx (+4 -2)
📝 landing/app/support/page.tsx (+4 -2)
📝 landing/app/terms-and-conditions/page.tsx (+4 -2)
📝 landing/helpers/metadata.ts (+7 -4)
➕ landing/public/android-icon-144x144.png (+0 -0)
📝 landing/public/android-icon-192x192.png (+0 -0)
➕ landing/public/android-icon-36x36.png (+0 -0)
➕ landing/public/android-icon-48x48.png (+0 -0)
➕ landing/public/android-icon-72x72.png (+0 -0)
➕ landing/public/android-icon-96x96.png (+0 -0)
📝 landing/public/feature-1-desktop.webp (+0 -0)
➕ landing/public/feature-1-mobile.webp (+0 -0)
📝 landing/public/feature-2-desktop.webp (+0 -0)
➕ landing/public/feature-2-mobile.webp (+0 -0)
📝 landing/public/feature-3-desktop.webp (+0 -0)

...and 6 more files

📄 Description

Until now we always displayed the same feature images on the landing page and it didn't matter if the user was on a desktop or mobile device. This is now changed so that we display different images on mobile devices (depending on the screen resolution).

Besides that we also moved the deprecated themeColor from the Metadata to the Viewport and added it to all pages.

Last but not least we added some missing Android icons, which were referenced in the manifest.json file, but where the icon didn't exist.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/137 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 2/11/2024 **Status:** ✅ Merged **Merged:** 2/11/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `landing-add-feature-images-for-mobile` --- ### 📝 Commits (1) - [`aa795e6`](https://github.com/feeddeck/feeddeck/commit/aa795e6403d981fdd37d14bc87f6a26ed4e4c824) [landing] Add Feature Images for Mobile Screens ### 📊 Changes **26 files changed** (+126 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `landing/app/download/page.tsx` (+4 -2) 📝 `landing/app/get-started/desktop/page.tsx` (+4 -2) 📝 `landing/app/get-started/mobile/page.tsx` (+4 -2) 📝 `landing/app/page.tsx` (+51 -12) 📝 `landing/app/pricing/page.tsx` (+4 -2) 📝 `landing/app/privacy-policy/page.tsx` (+4 -2) 📝 `landing/app/support/page.tsx` (+4 -2) 📝 `landing/app/terms-and-conditions/page.tsx` (+4 -2) 📝 `landing/helpers/metadata.ts` (+7 -4) ➕ `landing/public/android-icon-144x144.png` (+0 -0) 📝 `landing/public/android-icon-192x192.png` (+0 -0) ➕ `landing/public/android-icon-36x36.png` (+0 -0) ➕ `landing/public/android-icon-48x48.png` (+0 -0) ➕ `landing/public/android-icon-72x72.png` (+0 -0) ➕ `landing/public/android-icon-96x96.png` (+0 -0) 📝 `landing/public/feature-1-desktop.webp` (+0 -0) ➕ `landing/public/feature-1-mobile.webp` (+0 -0) 📝 `landing/public/feature-2-desktop.webp` (+0 -0) ➕ `landing/public/feature-2-mobile.webp` (+0 -0) 📝 `landing/public/feature-3-desktop.webp` (+0 -0) _...and 6 more files_ </details> ### 📄 Description Until now we always displayed the same feature images on the landing page and it didn't matter if the user was on a desktop or mobile device. This is now changed so that we display different images on mobile devices (depending on the screen resolution). Besides that we also moved the deprecated `themeColor` from the `Metadata` to the `Viewport` and added it to all pages. Last but not least we added some missing Android icons, which were referenced in the `manifest.json` file, but where the icon didn't exist. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:58:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#138
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?