github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #124] [MERGED] [core] Add Missing SafeArea Widget #125

New Issue
Closed
opened 2025-10-31 16:57:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:57:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/124
Author: @ricoberger
Created: 1/31/2024
Status: ✅ Merged
Merged: 1/31/2024
Merged by: @ricoberger

Base: main ← Head: core-add-missing-sage-area-widget

📝 Commits (1)

  • 37d70f0 [core] Add Missing SafeArea Widget

📊 Changes

4 files changed (+246 additions, -229 deletions)

View changed files

📝 app/lib/widgets/settings/accounts/settings_accounts_github.dart (+66 -64)
📝 app/lib/widgets/settings/premium/settings_premium_inapp.dart (+72 -67)
📝 app/lib/widgets/settings/premium/settings_premium_stripe.dart (+55 -50)
📝 app/lib/widgets/settings/profile/settings_profile_customer_portal.dart (+53 -48)

📄 Description

Several widgets which where rendered within a modal bottom sheet didn't used a SafeArea widget in the body of the Scaffold widget, so that the action buttons on the bottom of the widget where not rendered in the correct position.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/124 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-add-missing-sage-area-widget` --- ### 📝 Commits (1) - [`37d70f0`](https://github.com/feeddeck/feeddeck/commit/37d70f05c2b2e604da649bf95d2292c233ae0720) [core] Add Missing `SafeArea` Widget ### 📊 Changes **4 files changed** (+246 additions, -229 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/settings/accounts/settings_accounts_github.dart` (+66 -64) 📝 `app/lib/widgets/settings/premium/settings_premium_inapp.dart` (+72 -67) 📝 `app/lib/widgets/settings/premium/settings_premium_stripe.dart` (+55 -50) 📝 `app/lib/widgets/settings/profile/settings_profile_customer_portal.dart` (+53 -48) </details> ### 📄 Description Several widgets which where rendered within a modal bottom sheet didn't used a `SafeArea` widget in the body of the `Scaffold` widget, so that the action buttons on the bottom of the widget where not rendered in the correct position. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:57:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?