github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #122] [MERGED] [core] Fix Naming of Files #123

New Issue
Closed
opened 2025-10-31 16:57:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:57:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/122
Author: @ricoberger
Created: 1/31/2024
Status: ✅ Merged
Merged: 1/31/2024
Merged by: @ricoberger

Base: main ← Head: core-fix-naming-of-files

📝 Commits (1)

  • ffddf9f [core] Fix Naming of Files

📊 Changes

3 files changed (+2 additions, -2 deletions)

View changed files

📝 app/lib/utils/desktop_signin_manager.dart (+0 -0)
📝 app/lib/utils/signin_with_apple.dart (+0 -0)
📝 app/lib/widgets/signin/signin.dart (+2 -2)

📄 Description

Fix the naming of some files: Instead of login we are always using the term sign in and already renamed the DesktopLoginManager to DesktopSignInManager in #106. During the renaming we forgot to rename the file which is now done.

We also renamed the sign_in_with_apple.dart file to signin_with_apple.dart, because the other files also do not contain an underscore between sign and in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/122 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-naming-of-files` --- ### 📝 Commits (1) - [`ffddf9f`](https://github.com/feeddeck/feeddeck/commit/ffddf9f5c9f254f1b2d0c4cf6ad87888d5ccbfb4) [core] Fix Naming of Files ### 📊 Changes **3 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/utils/desktop_signin_manager.dart` (+0 -0) 📝 `app/lib/utils/signin_with_apple.dart` (+0 -0) 📝 `app/lib/widgets/signin/signin.dart` (+2 -2) </details> ### 📄 Description Fix the naming of some files: Instead of login we are always using the term sign in and already renamed the `DesktopLoginManager` to `DesktopSignInManager` in #106. During the renaming we forgot to rename the file which is now done. We also renamed the `sign_in_with_apple.dart` file to `signin_with_apple.dart`, because the other files also do not contain an underscore between sign and in. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:57:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?