mirror of
https://github.com/harvard-edge/cs249r_book.git
synced 2026-05-09 02:11:56 -05:00
f4d91a06e7
The patch-application harness at book/tools/scripts/testing/apply_fix.sh
previously snapshotted pre/post violation counts using the now-removed
\`check rendering\` group and \`rendering --scope mitpress-*\` style-
rule scopes. Update to the semantic-group equivalents:
check rendering --path X → check all --path X
(broader coverage; the old rendering
group was a subset of what all covers)
rendering --scope mitpress-* → <new-group> --scope <scope>
per the commit 2 migration map
The 8 style-specific scope checks at the bottom of the script now use
a `group:scope` pair array for readability:
punctuation:vs-period (was mitpress-vs-period)
numbers:percent-in-captions (was mitpress-percent-in-captions)
punctuation:emdash (was mitpress-spaced-emdash)
punctuation:eg-ie-comma (was mitpress-eg-ie-comma)
refs:capitalized (was mitpress-capitalized-refs)
prose:above-below (was mitpress-above-below)
punctuation:hyphen-range (was mitpress-hyphen-range)
prose:acknowledgements (was mitpress-acknowledgements)
No other stale references to old scope paths remain anywhere (grepped
across .claude, book/, *.sh, *.py, *.md, *.yaml). The hook IDs in
.pre-commit-config.yaml (e.g. \`mitpress-vs-period\`) are intentionally
unchanged — hook IDs are a contract with CI and contributor git hooks;
ID renames are a separate follow-up.
Concludes the check-taxonomy refactor. Summary:
commit 1 — introduce 9 semantic check groups (additive)
commit 2 — migrate 26 pre-commit entries to semantic groups
commit 3 — remove `rendering` group; delete add_check.py
commit 4 — update apply_fix.sh test harness (this commit)
Final state: ./book/binder check --list shows 9 purpose-built groups in
place of the 28-scope rendering bucket. All pre-commit hooks pass
against baseline (bib-lint chain-run transient unrelated to refactor).