github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-23 07:23:03 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1216] [MERGED] fix(losses): clean up log_softmax implementation #9889

New Issue
Closed
opened 2026-05-08 10:52:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-08 10:52:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1216
Author: @minhdang26403
Created: 3/8/2026
Status: ✅ Merged
Merged: 3/15/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/log-softmax

📝 Commits (1)

  • 68cd5fc fix(losses): clean up log_softmax implementation to have clear variable names and reuse variables

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 tinytorch/src/04_losses/ABOUT.md (+4 -4)

📄 Description

The current sample log_softmax implementation has inconsistent variable names and does not re-use the shifted tensor variable. This commit attempts to fix these issues.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1216 **Author:** [@minhdang26403](https://github.com/minhdang26403) **Created:** 3/8/2026 **Status:** ✅ Merged **Merged:** 3/15/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/log-softmax` --- ### 📝 Commits (1) - [`68cd5fc`](https://github.com/harvard-edge/cs249r_book/commit/68cd5fcceba954d4e51da70ef98473feb0bc58b0) fix(losses): clean up log_softmax implementation to have clear variable names and reuse variables ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/04_losses/ABOUT.md` (+4 -4) </details> ### 📄 Description The current sample `log_softmax` implementation has inconsistent variable names and does not re-use the `shifted` tensor variable. This commit attempts to fix these issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-08 10:52:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?