github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-08 09:57:21 -05:00
Code Issues 81 Packages Projects Releases 24 Wiki Activity

[PR #1623] [MERGED] fix(kits): improve dark mode dropdown menu contrast #9229

New Issue
Closed
opened 2026-05-03 01:29:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-03 01:29:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1623
Author: @farhan523
Created: 5/2/2026
Status: ✅ Merged
Merged: 5/2/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/kits-dark-dropdown-menu

📝 Commits (1)

  • 1ca2de4 fix(kits): improve dark mode dropdown menu contrast

📊 Changes

1 file changed (+32 additions, -0 deletions)

View changed files

📝 kits/assets/styles/dark-mode.scss (+32 -0)

📄 Description

Summary

  • fix Kits dark mode navbar dropdown background so menus no longer render on a white surface
  • improve dropdown item, header, divider, and hover-state contrast for readability

Before

Screenshot 2026-05-02 090634

After

Screenshot 2026-05-02 090626

Testing

  • verified in local Kits preview in dark mode

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1623 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/2/2026 **Status:** ✅ Merged **Merged:** 5/2/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/kits-dark-dropdown-menu` --- ### 📝 Commits (1) - [`1ca2de4`](https://github.com/harvard-edge/cs249r_book/commit/1ca2de441f971535529911db679be14db9581bdc) fix(kits): improve dark mode dropdown menu contrast ### 📊 Changes **1 file changed** (+32 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `kits/assets/styles/dark-mode.scss` (+32 -0) </details> ### 📄 Description ## Summary - fix Kits dark mode navbar dropdown background so menus no longer render on a white surface - improve dropdown item, header, divider, and hover-state contrast for readability ## Before - <img width="723" height="218" alt="Screenshot 2026-05-02 090634" src="https://github.com/user-attachments/assets/e341e0cb-0dd2-4762-a936-01734e819440" /> ## After - <img width="650" height="243" alt="Screenshot 2026-05-02 090626" src="https://github.com/user-attachments/assets/04f05781-4373-4f42-a68b-754f8f948d69" /> ## Testing - verified in local Kits preview in dark mode --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-03 01:29:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?