[PR #1620] [MERGED] chore(codespell): permanently clear false positives blocking PR CI #9226

New Issue

GiteaMirror · 2026-05-03T01:29:27-05:00

GiteaMirror commented

2026-05-03 01:29:27 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1620
Author: @profvjreddi
Created: 4/30/2026
Status: ✅ Merged
Merged: 4/30/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/codespell-permanent-cleanup

📝 Commits (1)

174f1e6 chore(codespell): permanently clear false positives blocking PR CI

📊 Changes

3 files changed (+5 additions, -1 deletions)

View changed files

📝 .codespell-ignore-words.txt (+2 -0)
📝 .gitignore (+3 -0)
➖ interviews/vault-cli/check_results.json (+0 -1)

📄 Description

Summary

Three pre-existing codespell hits on dev have been blocking the Check for spelling errors job on every new PR. They've been there long enough that 1605 and 1608 (both touching files codespell scans) failed CI through no fault of their own. Fix at the root.

File	Word	Disposition
`interviews/vault-cli/check_results.json`	`lement`	Removed file + gitignored. It's a `vault check` output dump (committed once during a refinement pass), not source content. `lement` was a truncated word inside a pydantic error message.
`interviews/vault/exemplars/edge/edge-fill-00236.yaml` (line 12)	`Re-using`	Added `re-using` to `.codespell-ignore-words.txt`. Intentional hyphenated English.
`interviews/vault/questions/edge/power/edge-0089.yaml` (line 37)	`Pre-selecting`	Added `pre-selecting` to `.codespell-ignore-words.txt`. The list already keeps `pre-select`, `Pre-select`, `pre-selected` for the same reason — this just extends the existing convention.

Why this approach

Removing check_results.json: it's a generated artifact that should never have been tracked. Gitignoring the path means future regenerations don't repollute the repo, so this can't recur.
Adding to ignore list (not rewriting the YAMLs): the project has already decided to keep hyphenated pre-select etc. in the ignore list rather than rewriting source. Following the existing convention.

Test plan

git ls-files -z | xargs -0 codespell --toml pyproject.toml → exit 0 locally
CI Check for spelling errors turns green on this PR
After merge, re-run CI on #1605 and #1608 to confirm they unblock

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1620 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/30/2026 **Status:** ✅ Merged **Merged:** 4/30/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/codespell-permanent-cleanup` --- ### 📝 Commits (1) - [`174f1e6`](https://github.com/harvard-edge/cs249r_book/commit/174f1e6681e9a902776d4752f1d4bd9a23d3276c) chore(codespell): permanently clear false positives blocking PR CI ### 📊 Changes **3 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.codespell-ignore-words.txt` (+2 -0) 📝 `.gitignore` (+3 -0) ➖ `interviews/vault-cli/check_results.json` (+0 -1) </details> ### 📄 Description ## Summary Three pre-existing codespell hits on `dev` have been blocking the **Check for spelling errors** job on every new PR. They've been there long enough that 1605 and 1608 (both touching files codespell scans) failed CI through no fault of their own. Fix at the root. | File | Word | Disposition | |---|---|---| | `interviews/vault-cli/check_results.json` | `lement` | Removed file + gitignored. It's a `vault check` output dump (committed once during a refinement pass), not source content. `lement` was a truncated word inside a pydantic error message. | | `interviews/vault/exemplars/edge/edge-fill-00236.yaml` (line 12) | `Re-using` | Added `re-using` to `.codespell-ignore-words.txt`. Intentional hyphenated English. | | `interviews/vault/questions/edge/power/edge-0089.yaml` (line 37) | `Pre-selecting` | Added `pre-selecting` to `.codespell-ignore-words.txt`. The list already keeps `pre-select`, `Pre-select`, `pre-selected` for the same reason — this just extends the existing convention. | ## Why this approach - Removing `check_results.json`: it's a generated artifact that should never have been tracked. Gitignoring the path means future regenerations don't repollute the repo, so this can't recur. - Adding to ignore list (not rewriting the YAMLs): the project has already decided to keep hyphenated `pre-select` etc. in the ignore list rather than rewriting source. Following the existing convention. ## Test plan - [x] `git ls-files -z | xargs -0 codespell --toml pyproject.toml` → exit 0 locally - [ ] CI **Check for spelling errors** turns green on this PR - [ ] After merge, re-run CI on #1605 and #1608 to confirm they unblock 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-03 01:29:27 -05:00

GiteaMirror closed this issue

2026-05-03 01:29:28 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9226