[PR #1605] [MERGED] fix(site/community): restore spotlight quote visibility in dark mode #9216

New Issue

GiteaMirror · 2026-05-03T01:29:08-05:00

GiteaMirror commented

2026-05-03 01:29:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1605
Author: @farhan523
Created: 4/30/2026
Status: ✅ Merged
Merged: 4/30/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/community-spotlight-dark-mode

📝 Commits (2)

85bbfbe fix(site/community): restore spotlight quote visibility in dark mode
30e5527 Merge branch 'dev' into fix/community-spotlight-dark-mode

📊 Changes

1 file changed (+24 additions, -6 deletions)

View changed files

📝 site/community/community.css (+24 -6)

📄 Description

Summary

The textbook bootstrap theme styles blockquote with a near-white background and a dark muted text color. On the community Spotlight cards in dark mode this rendered the quotes as faint text on a stray light rectangle (see Before).
Scoped neutralization of background / padding / border / border-radius on .spotlight-quote, plus explicit color: #e5e7eb !important dark-mode overrides keyed on both .quarto-dark and [data-bs-theme="dark"] (matches the pattern already used by other community elements in community.css).
Light mode is unchanged.

Before

After

Test plan

quarto preview site and open /community/ in dark mode — both spotlight quotes render legibly with no white rectangle behind them.
Toggle to light mode — quotes still readable, card layout unchanged.
Toggle dark/light a few times — no flash of light background.
Other pages that render blockquote (e.g. textbook chapters) are unaffected (rules are scoped to .spotlight-quote).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1605 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 4/30/2026 **Status:** ✅ Merged **Merged:** 4/30/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/community-spotlight-dark-mode` --- ### 📝 Commits (2) - [`85bbfbe`](https://github.com/harvard-edge/cs249r_book/commit/85bbfbeec602c5ff0570e5f1cdf0542caac425ca) fix(site/community): restore spotlight quote visibility in dark mode - [`30e5527`](https://github.com/harvard-edge/cs249r_book/commit/30e5527e4e86eec8c63802576748a52f91499104) Merge branch 'dev' into fix/community-spotlight-dark-mode ### 📊 Changes **1 file changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `site/community/community.css` (+24 -6) </details> ### 📄 Description ## Summary - The textbook bootstrap theme styles `blockquote` with a near-white background and a dark muted text color. On the community Spotlight cards in dark mode this rendered the quotes as faint text on a stray light rectangle (see *Before*). - Scoped neutralization of `background` / `padding` / `border` / `border-radius` on `.spotlight-quote`, plus explicit `color: #e5e7eb !important` dark-mode overrides keyed on both `.quarto-dark` and `[data-bs-theme="dark"]` (matches the pattern already used by other community elements in `community.css`). - Light mode is unchanged. ## Before <img width="1058" height="332" alt="Screenshot 2026-04-30 094801" src="https://github.com/user-attachments/assets/c16bdda8-5a45-4369-9c7b-2984169602bf" /> ## After <img width="1082" height="354" alt="Screenshot 2026-04-30 094814" src="https://github.com/user-attachments/assets/0d9be05d-b646-4c09-9bd3-40d8441fe7f1" /> ## Test plan - [ ] `quarto preview site` and open `/community/` in dark mode — both spotlight quotes render legibly with no white rectangle behind them. - [ ] Toggle to light mode — quotes still readable, card layout unchanged. - [ ] Toggle dark/light a few times — no flash of light background. - [ ] Other pages that render `blockquote` (e.g. textbook chapters) are unaffected (rules are scoped to `.spotlight-quote`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-03 01:29:08 -05:00

GiteaMirror closed this issue

2026-05-03 01:29:08 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9216