github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-08 09:57:21 -05:00
Code Issues 81 Packages Projects Releases 24 Wiki Activity

[PR #1447] [MERGED] feat(ci): E2E smoke + gate publish on validate-vault #9116

New Issue
Closed
opened 2026-05-03 01:21:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-03 01:21:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1447
Author: @profvjreddi
Created: 4/22/2026
Status: ✅ Merged
Merged: 4/22/2026
Merged by: @profvjreddi

Base: dev ← Head: feat/ci-e2e-smoke

📝 Commits (1)

  • 6bb13dc feat(ci): E2E smoke + gate publish on validate-vault

📊 Changes

3 files changed (+254 additions, -4 deletions)

View changed files

📝 .github/workflows/staffml-publish-live.yml (+14 -3)
📝 .github/workflows/staffml-validate-dev.yml (+61 -1)
➕ interviews/staffml/scripts/e2e-smoke.py (+179 -0)

📄 Description

Two pre-release polish items.

1. Playwright E2E smoke in staffml-validate-dev — new job loads 6 routes in headless Chromium and asserts zero uncaught errors + zero console.errors (with allowlist for Next.js static-export quirks). Would have caught the hydration shape-mismatch bug (PR #1440) before merge.

2. validate-vault gates publish-live — second guard job mirrors the existing validate-dev gate. A YAML-only PR that broke chain integrity used to slip through; now doesn't.

Local dry-run of e2e-smoke.py: all 6 routes pass, zero errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1447 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/22/2026 **Status:** ✅ Merged **Merged:** 4/22/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `feat/ci-e2e-smoke` --- ### 📝 Commits (1) - [`6bb13dc`](https://github.com/harvard-edge/cs249r_book/commit/6bb13dcf9ec9960534c7d74e2d886deacf53744f) feat(ci): E2E smoke + gate publish on validate-vault ### 📊 Changes **3 files changed** (+254 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/staffml-publish-live.yml` (+14 -3) 📝 `.github/workflows/staffml-validate-dev.yml` (+61 -1) ➕ `interviews/staffml/scripts/e2e-smoke.py` (+179 -0) </details> ### 📄 Description Two pre-release polish items. **1. Playwright E2E smoke in `staffml-validate-dev`** — new job loads 6 routes in headless Chromium and asserts zero uncaught errors + zero console.errors (with allowlist for Next.js static-export quirks). Would have caught the hydration shape-mismatch bug (PR #1440) before merge. **2. `validate-vault` gates publish-live** — second guard job mirrors the existing validate-dev gate. A YAML-only PR that broke chain integrity used to slip through; now doesn't. Local dry-run of `e2e-smoke.py`: all 6 routes pass, zero errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-03 01:21:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?