[PR #1442] [MERGED] feat(staffml): flip default theme to light for ecosystem consistency #9111

New Issue

GiteaMirror · 2026-05-03T01:21:05-05:00

GiteaMirror commented

2026-05-03 01:21:05 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1442
Author: @profvjreddi
Created: 4/22/2026
Status: ✅ Merged
Merged: 4/22/2026
Merged by: @profvjreddi

Base: dev ← Head: feat/light-mode-default

📝 Commits (1)

e5ccbcc feat(staffml): flip default theme to light for ecosystem consistency

📊 Changes

2 files changed (+16 additions, -11 deletions)

View changed files

📝 interviews/staffml/public/theme-bootstrap.js (+6 -3)
📝 interviews/staffml/src/components/ThemeProvider.tsx (+10 -8)

📄 Description

Matches mlsysbook.ai's book/labs/kits/slides/instructors sites (all light-by-default). No visual whiplash crossing between the book and staffml. User's persisted choice still wins, cross-site mirror to quarto-color-scheme still works.

theme-bootstrap.js fallback → light
ThemeProvider.tsx defaults → light (3 spots)
Stored preference flow unchanged — anyone who explicitly toggled dark keeps dark
Build green locally

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1442 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/22/2026 **Status:** ✅ Merged **Merged:** 4/22/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `feat/light-mode-default` --- ### 📝 Commits (1) - [`e5ccbcc`](https://github.com/harvard-edge/cs249r_book/commit/e5ccbcc6527fc049f7161c317a48865228fe824c) feat(staffml): flip default theme to light for ecosystem consistency ### 📊 Changes **2 files changed** (+16 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `interviews/staffml/public/theme-bootstrap.js` (+6 -3) 📝 `interviews/staffml/src/components/ThemeProvider.tsx` (+10 -8) </details> ### 📄 Description Matches mlsysbook.ai's book/labs/kits/slides/instructors sites (all light-by-default). No visual whiplash crossing between the book and staffml. User's persisted choice still wins, cross-site mirror to `quarto-color-scheme` still works. - `theme-bootstrap.js` fallback → light - `ThemeProvider.tsx` defaults → light (3 spots) - Stored preference flow unchanged — anyone who explicitly toggled dark keeps dark - Build green locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-03 01:21:05 -05:00

GiteaMirror closed this issue

2026-05-03 01:21:07 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9111