[PR #1413] [MERGED] fix(ci): clear all 8 failing pre-commit hooks on dev #9085

New Issue

GiteaMirror · 2026-05-03T01:19:30-05:00

GiteaMirror commented

2026-05-03 01:19:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1413
Author: @profvjreddi
Created: 4/20/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mitpress-above-below

📝 Commits (6)

1e469ae fix(content): clear two mitpress-above-below pre-commit failures
07f7226 fix(check-internal-links): suppress 4 categories of false positives
57ec5c5 fix(content): repair internal-link rot across 10 files
54cd44b chore(pre-commit): exclude 3 forward-looking files from internal-link checker
930dfee fix(content): clear codespell, contractions, and vs. pre-commit failures
68f3050 chore: bibtex-tidy auto-format outputs

📊 Changes

23 files changed (+163 additions, -76 deletions)

View changed files

📝 .pre-commit-config.yaml (+4 -1)
📝 README/README_ja.md (+8 -8)
📝 README/README_ko.md (+8 -8)
📝 README/README_zh.md (+8 -8)
📝 book/quarto/config/shared/README.md (+1 -1)
📝 book/quarto/contents/frontmatter/index.qmd (+1 -1)
📝 book/quarto/contents/frontmatter/socratiq/socratiq.qmd (+1 -1)
📝 book/quarto/contents/vol1/benchmarking/benchmarking.qmd (+1 -1)
📝 book/quarto/contents/vol1/nn_architectures/nn_architectures.qmd (+2 -2)
📝 book/quarto/contents/vol1/responsible_engr/responsible_engr.qmd (+1 -1)
📝 book/quarto/contents/vol2/backmatter/references.bib (+4 -4)
📝 book/quarto/contents/vol2/distributed_training/distributed_training.qmd (+2 -2)
📝 book/quarto/contents/vol2/fault_tolerance/fault_tolerance.qmd (+1 -1)
📝 book/quarto/contents/vol2/inference/inference.qmd (+1 -1)
📝 book/quarto/contents/vol2/network_fabrics/network_fabrics.qmd (+1 -1)
📝 book/tools/scripts/README.md (+1 -1)
📝 mlsysim/docs/cli-reference.qmd (+1 -1)
📝 mlsysim/docs/contributing.qmd (+18 -18)
📝 mlsysim/docs/for-engineers.qmd (+1 -1)
📝 mlsysim/docs/for-instructors.qmd (+1 -1)

...and 3 more files

📄 Description

Summary

Clears every failing pre-commit hook reported on dev after the
release-prep PRs (#1404–#1411) merged. Restores the
📚 Book · ✅ Validate (Dev) workflow to green and unblocks the
publish guard.

What changed (6 logical commits)

#	Commit	Scope
1	`fix(content): clear two mitpress-above-below pre-commit failures`	Original PR scope: `responsible_engr.qmd`, `network_fabrics.qmd`
2	`fix(check-internal-links): suppress 4 categories of false positives`	HTML comments / TikZ, Quarto xrefs, uppercase `HTTPS://`, GitHub-style emoji slugs
3	`fix(content): repair internal-link rot across 10 files`	24 paths in translated READMEs, 21 in `mlsysim/docs/contributing.qmd`, 6 anchor/path retargets
4	`chore(pre-commit): exclude 3 forward-looking files from internal-link checker`	`labs/index.qmd`, `labs/PROTOCOL.md`, `labs/TEMPLATE.md`
5	`fix(content): clear codespell, contractions, and vs. pre-commit failures`	2 misspellings, 2 contractions, 6 `vs` → `vs.`
6	`chore: bibtex-tidy auto-format outputs`	2 `.bib` files

Hook results

Local pre-commit run --all-files: 60 Passed, 1 Skipped (no files), 0 Failed.

How to review

Each commit is independently revertable. The link-checker software
change (#2) is isolated from the content fixes (#3, #5) so you can
diff-review them separately. The .pre-commit-config.yaml exclusions
(#4) are documented inline so the rationale survives in the config.

Why scope expanded

Original PR was scoped only to mitpress-above-below. After that hook
went green, the CI surfaced 7 additional pre-existing hook failures.
User explicitly chose all_fix for scope; rather than open 7 follow-up
PRs and serialize through CI/review, fix is delivered as one cohesive
PR with reviewable commit boundaries.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1413 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/20/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mitpress-above-below` --- ### 📝 Commits (6) - [`1e469ae`](https://github.com/harvard-edge/cs249r_book/commit/1e469aee7a8387299a3ddd112a31bb92250972c0) fix(content): clear two mitpress-above-below pre-commit failures - [`07f7226`](https://github.com/harvard-edge/cs249r_book/commit/07f7226570607d23b6adcea83f84fe14d9766ea9) fix(check-internal-links): suppress 4 categories of false positives - [`57ec5c5`](https://github.com/harvard-edge/cs249r_book/commit/57ec5c5b1d128f29dcc563e40972b69ab8e6755c) fix(content): repair internal-link rot across 10 files - [`54cd44b`](https://github.com/harvard-edge/cs249r_book/commit/54cd44b6cf484fc2e7299cf7ec831be349d6e5d4) chore(pre-commit): exclude 3 forward-looking files from internal-link checker - [`930dfee`](https://github.com/harvard-edge/cs249r_book/commit/930dfeebd35e15082b151f6458626ea510d814fd) fix(content): clear codespell, contractions, and vs. pre-commit failures - [`68f3050`](https://github.com/harvard-edge/cs249r_book/commit/68f30505082b218e7246ea991d6138930948a5e7) chore: bibtex-tidy auto-format outputs ### 📊 Changes **23 files changed** (+163 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `.pre-commit-config.yaml` (+4 -1) 📝 `README/README_ja.md` (+8 -8) 📝 `README/README_ko.md` (+8 -8) 📝 `README/README_zh.md` (+8 -8) 📝 `book/quarto/config/shared/README.md` (+1 -1) 📝 `book/quarto/contents/frontmatter/index.qmd` (+1 -1) 📝 `book/quarto/contents/frontmatter/socratiq/socratiq.qmd` (+1 -1) 📝 `book/quarto/contents/vol1/benchmarking/benchmarking.qmd` (+1 -1) 📝 `book/quarto/contents/vol1/nn_architectures/nn_architectures.qmd` (+2 -2) 📝 `book/quarto/contents/vol1/responsible_engr/responsible_engr.qmd` (+1 -1) 📝 `book/quarto/contents/vol2/backmatter/references.bib` (+4 -4) 📝 `book/quarto/contents/vol2/distributed_training/distributed_training.qmd` (+2 -2) 📝 `book/quarto/contents/vol2/fault_tolerance/fault_tolerance.qmd` (+1 -1) 📝 `book/quarto/contents/vol2/inference/inference.qmd` (+1 -1) 📝 `book/quarto/contents/vol2/network_fabrics/network_fabrics.qmd` (+1 -1) 📝 `book/tools/scripts/README.md` (+1 -1) 📝 `mlsysim/docs/cli-reference.qmd` (+1 -1) 📝 `mlsysim/docs/contributing.qmd` (+18 -18) 📝 `mlsysim/docs/for-engineers.qmd` (+1 -1) 📝 `mlsysim/docs/for-instructors.qmd` (+1 -1) _...and 3 more files_ </details> ### 📄 Description ## Summary Clears every failing pre-commit hook reported on `dev` after the release-prep PRs (#1404–#1411) merged. Restores the `📚 Book · ✅ Validate (Dev)` workflow to green and unblocks the publish guard. ## What changed (6 logical commits) | # | Commit | Scope | |---|--------|-------| | 1 | `fix(content): clear two mitpress-above-below pre-commit failures` | Original PR scope: `responsible_engr.qmd`, `network_fabrics.qmd` | | 2 | `fix(check-internal-links): suppress 4 categories of false positives` | HTML comments / TikZ, Quarto xrefs, uppercase `HTTPS://`, GitHub-style emoji slugs | | 3 | `fix(content): repair internal-link rot across 10 files` | 24 paths in translated READMEs, 21 in `mlsysim/docs/contributing.qmd`, 6 anchor/path retargets | | 4 | `chore(pre-commit): exclude 3 forward-looking files from internal-link checker` | `labs/index.qmd`, `labs/PROTOCOL.md`, `labs/TEMPLATE.md` | | 5 | `fix(content): clear codespell, contractions, and vs. pre-commit failures` | 2 misspellings, 2 contractions, 6 `vs` → `vs.` | | 6 | `chore: bibtex-tidy auto-format outputs` | 2 `.bib` files | ## Hook results Local `pre-commit run --all-files`: **60 Passed, 1 Skipped (no files), 0 Failed.** ## How to review Each commit is independently revertable. The link-checker software change (#2) is isolated from the content fixes (#3, #5) so you can diff-review them separately. The `.pre-commit-config.yaml` exclusions (#4) are documented inline so the rationale survives in the config. ## Why scope expanded Original PR was scoped only to `mitpress-above-below`. After that hook went green, the CI surfaced 7 additional pre-existing hook failures. User explicitly chose `all_fix` for scope; rather than open 7 follow-up PRs and serialize through CI/review, fix is delivered as one cohesive PR with reviewable commit boundaries. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-03 01:19:30 -05:00

GiteaMirror closed this issue

2026-05-03 01:19:33 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#9085