github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 13:31:55 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1152] [MERGED] fix(tito-milestone): align bold cyan frame #8911

New Issue
Closed
opened 2026-05-03 01:05:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-03 01:05:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1152
Author: @AndreaMattiaGaravagno
Created: 2/3/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/milestone-frame-alignment

📝 Commits (1)

  • 5f6a846 fix(tito-milestone): align bold cyan frame and correct "Press Enter" color

📊 Changes

1 file changed (+14 additions, -5 deletions)

View changed files

📝 tinytorch/tito/commands/milestone.py (+14 -5)

📄 Description

Previously, frame borders were calculated based on string length/character count. This caused misalignment when using multi-column characters (like emojis or CJK characters) which occupy two cells but count as one or more characters. Now we count cells to ensure proper alignment of frames.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1152 **Author:** [@AndreaMattiaGaravagno](https://github.com/AndreaMattiaGaravagno) **Created:** 2/3/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/milestone-frame-alignment` --- ### 📝 Commits (1) - [`5f6a846`](https://github.com/harvard-edge/cs249r_book/commit/5f6a8468f3c9392102463da1c8aeab2bb990105b) fix(tito-milestone): align bold cyan frame and correct "Press Enter" color ### 📊 Changes **1 file changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/tito/commands/milestone.py` (+14 -5) </details> ### 📄 Description Previously, frame borders were calculated based on string length/character count. This caused misalignment when using multi-column characters (like emojis or CJK characters) which occupy two cells but count as one or more characters. Now we count cells to ensure proper alignment of frames. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-03 01:05:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#8911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?