github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-22 14:03:46 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1101] [CLOSED] Fix: Add requires_grad parameter to Tensor.__init__ for Linear layer compatibility #8888

New Issue
Closed
opened 2026-05-03 01:03:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-03 01:03:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1101
Author: @mrinalchaturvedi27
Created: 1/4/2026
Status: ❌ Closed

Base: dev ← Head: fix-tensor-requires-grad

📝 Commits (1)

  • f8ebd25 Fix: Add requires_grad parameter to Tensor.init to support autograd flag used in Linear layer

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 tinytorch/src/01_tensor/01_tensor.py (+2 -1)

📄 Description

  • Added requires_grad parameter to Tensor.__init__ in tinytorch/src/01_tensor/01_tensor.py
  • Fixes TypeError caused by Tensor(weight_data, requires_grad=True) in Linear layer
  • Ensures compatibility with autograd flag usage across activation and layer modules
  • Tested locally: Linear layer unit test passes after this change

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1101 **Author:** [@mrinalchaturvedi27](https://github.com/mrinalchaturvedi27) **Created:** 1/4/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-tensor-requires-grad` --- ### 📝 Commits (1) - [`f8ebd25`](https://github.com/harvard-edge/cs249r_book/commit/f8ebd25a7fcb815d2188631ab49da694d04bafd0) Fix: Add requires_grad parameter to Tensor.__init__ to support autograd flag used in Linear layer ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/01_tensor/01_tensor.py` (+2 -1) </details> ### 📄 Description - Added `requires_grad` parameter to `Tensor.__init__` in `tinytorch/src/01_tensor/01_tensor.py` - Fixes TypeError caused by `Tensor(weight_data, requires_grad=True)` in Linear layer - Ensures compatibility with autograd flag usage across activation and layer modules - Tested locally: Linear layer unit test passes after this change --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-03 01:03:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#8888
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?