[PR #1412] [MERGED] fix(mlsysim): add missing contributors (VJ as #1, Zeljko Hrcek) #8179

New Issue

GiteaMirror · 2026-04-27T17:28:59-05:00

GiteaMirror commented

2026-04-27 17:28:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1412
Author: @profvjreddi
Created: 4/19/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mlsysim-contributors

📝 Commits (1)

0e9f083 fix(mlsysim): add missing contributors (VJ as #1, Zeljko Hrcek)

📊 Changes

2 files changed (+24 additions, -0 deletions)

View changed files

📝 mlsysim/.all-contributorsrc (+22 -0)
📝 mlsysim/README.md (+2 -0)

📄 Description

Why

The MLSys·im contributor list rendered on the site was missing two real contributors. Caught during release prep:

Contributor	Commits to `mlsysim/`	Status before this PR
Vijay Janapa Reddi (`profvjreddi`)	196 (incl. the project's first commit, `c56cb62c25`, 2026-03-01)	Missing
Peter Koellner (`asgalon`)	0 (bug reports / docs)	Present
Zeljko Hrcek (`hzeljko`)	1 (`dd9585543c`, "Add compatibility layer for textbook scenarios")	Missing
Rocky (`Shashank-Tripathi-07`)	1	Present

This was an mlsysim-only outlier — both labs/.all-contributorsrc and the root .all-contributorsrc already list VJ as #1, and the root list already includes Zeljko.

What

Add VJ to mlsysim/.all-contributorsrc as the first entry — code, design, doc, ideas, maintenance (rendered 🧑‍💻 🎨 ✍️ 🤔 🚧). Categories chosen to reflect originator + ongoing-lead role, going beyond the labs code+design+doc baseline.
Add Zeljko Hrcek (hzeljko) — code (🧑‍💻).
Regenerate the matching <table> block in mlsysim/README.md so the bot's source-of-truth JSON and the rendered HTML stay in lockstep. Final row order: VJ, Peter, Zeljko, Rocky.
Existing Peter and Rocky entries preserved verbatim.

Verification

JSON validates (python3 -c "import json; json.load(open('mlsysim/.all-contributorsrc'))").
Diff is +24 / −0; no formatting churn elsewhere.
Table HTML mirrors the JSON one-for-one.

Notes

Avatar URL formats are mixed (/u/<id>?v=4 for the existing two entries vs. /<login> for VJ/Zeljko). Both work; matched the format used in the root .all-contributorsrc for the new entries. The all-contributors bot will normalize on its next run if anyone uses it.
The mlsysim README's contribution-emoji legend uses custom emojis (🪲 ⚡ 📚 🎨 🧠) but the bot generates standard all-contributors ones (🐛 🧑‍💻 ✍️ 🎨 🤔). That mismatch is pre-existing and out of scope for this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1412 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/19/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mlsysim-contributors` --- ### 📝 Commits (1) - [`0e9f083`](https://github.com/harvard-edge/cs249r_book/commit/0e9f0838d31c472c361ae0ccdd78504384e6e7dd) fix(mlsysim): add missing contributors (VJ as #1, Zeljko Hrcek) ### 📊 Changes **2 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/.all-contributorsrc` (+22 -0) 📝 `mlsysim/README.md` (+2 -0) </details> ### 📄 Description ## Why The MLSys·im contributor list rendered on the site was missing two real contributors. Caught during release prep: | Contributor | Commits to `mlsysim/` | Status before this PR | | --- | ---: | --- | | Vijay Janapa Reddi (`profvjreddi`) | **196** (incl. the project's first commit, `c56cb62c25`, 2026-03-01) | **Missing** | | Peter Koellner (`asgalon`) | 0 (bug reports / docs) | Present | | Zeljko Hrcek (`hzeljko`) | 1 (`dd9585543c`, "Add compatibility layer for textbook scenarios") | **Missing** | | Rocky (`Shashank-Tripathi-07`) | 1 | Present | This was an mlsysim-only outlier — both `labs/.all-contributorsrc` and the root `.all-contributorsrc` already list VJ as #1, and the root list already includes Zeljko. ## What - Add VJ to `mlsysim/.all-contributorsrc` as the **first** entry — `code, design, doc, ideas, maintenance` (rendered 🧑‍💻 🎨 ✍️ 🤔 🚧). Categories chosen to reflect originator + ongoing-lead role, going beyond the labs `code+design+doc` baseline. - Add Zeljko Hrcek (`hzeljko`) — `code` (🧑‍💻). - Regenerate the matching `<table>` block in `mlsysim/README.md` so the bot's source-of-truth JSON and the rendered HTML stay in lockstep. Final row order: VJ, Peter, Zeljko, Rocky. - Existing Peter and Rocky entries preserved verbatim. ## Verification - JSON validates (`python3 -c "import json; json.load(open('mlsysim/.all-contributorsrc'))"`). - Diff is +24 / −0; no formatting churn elsewhere. - Table HTML mirrors the JSON one-for-one. ## Notes - Avatar URL formats are mixed (`/u/<id>?v=4` for the existing two entries vs. `/<login>` for VJ/Zeljko). Both work; matched the format used in the root `.all-contributorsrc` for the new entries. The all-contributors bot will normalize on its next run if anyone uses it. - The mlsysim README's contribution-emoji **legend** uses custom emojis (🪲 ⚡ 📚 🎨 🧠) but the bot generates standard all-contributors ones (🐛 🧑‍💻 ✍️ 🎨 🤔). That mismatch is pre-existing and out of scope for this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-27 17:28:59 -05:00

GiteaMirror closed this issue

2026-04-27 17:29:01 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#8179