github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-08 18:01:20 -05:00
Code Issues 81 Packages Projects Releases 24 Wiki Activity

[PR #1321] [MERGED] fix: export DecisionLog and FailureBanner from mlsysim.labs #8117

New Issue
Closed
opened 2026-04-27 17:25:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-27 17:25:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1321
Author: @Shashank-Tripathi-07
Created: 4/11/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/labs-missing-exports-v3

📝 Commits (1)

  • 08d1a1c fix: export DecisionLog and FailureBanner from mlsysim.labs

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 mlsysim/labs/__init__.py (+4 -0)

📄 Description

Problem

DecisionLog and FailureBanner are defined in mlsysim/labs/components.py and imported directly by 14+ lab notebooks, but were missing from mlsysim/labs/__init__.py.

Any lab using the public API:

from mlsysim.labs import DecisionLog
from mlsysim.labs import FailureBanner

raises ImportError at runtime.

Fix

Add both to the import block and __all__ in mlsysim/labs/__init__.py.

Verification

from mlsysim.labs import DecisionLog, FailureBanner  # ✓

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1321 **Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07) **Created:** 4/11/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/labs-missing-exports-v3` --- ### 📝 Commits (1) - [`08d1a1c`](https://github.com/harvard-edge/cs249r_book/commit/08d1a1cf0165d358dcca02fae70127774b91ed1e) fix: export DecisionLog and FailureBanner from mlsysim.labs ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/labs/__init__.py` (+4 -0) </details> ### 📄 Description ## Problem `DecisionLog` and `FailureBanner` are defined in `mlsysim/labs/components.py` and imported directly by 14+ lab notebooks, but were missing from `mlsysim/labs/__init__.py`. Any lab using the public API: ```python from mlsysim.labs import DecisionLog from mlsysim.labs import FailureBanner ``` raises `ImportError` at runtime. ## Fix Add both to the import block and `__all__` in `mlsysim/labs/__init__.py`. ## Verification ```python from mlsysim.labs import DecisionLog, FailureBanner # ✓ ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-27 17:25:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#8117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?