github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-23 23:43:14 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

Incorrect program link in the "Testing the ToF (Time of Flight) Sensor" section #76

New Issue
Closed
opened 2026-03-22 15:24:37 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-03-22 15:24:37 -05:00
Owner
Copy Link

Originally created by @mouseart on GitHub (Mar 8, 2024).

I noticed an inconsistency in the "Testing the ToF (Time of Flight) Sensor" section of your document. The text mentions installing the VL53L1X library in the Arduino IDE and running a sketch named proximity_detection.ino. However, the provided link https://github.com/Mjrovai/Arduino_Nicla_Vision/blob/main/Micropython/distance_image_meter.py leads to a MicroPython program distance_image_meter.py intended for use with the OpenMV camera.

The linked program does not match the description in the document, which specifically refers to an Arduino sketch named proximity_detection.ino. I searched for proximity_detection.ino on GitHub but could not find any relevant results.

Could you please review this section and update the link to point to the correct Arduino sketch that demonstrates the usage of the VL53L1X sensor with the Arduino IDE? If the mentioned proximity_detection.ino sketch is not available, it would be helpful to provide a suitable alternative or update the document text to match the linked program.

Thank you for your attention to this matter and for providing clarity to the readers of your document.

Best regards,
Leon Feng

Originally created by @mouseart on GitHub (Mar 8, 2024). I noticed an inconsistency in the "[Testing the ToF (Time of Flight) Sensor](https://harvard-edge.github.io/cs249r_book/contents/niclav_sys/niclav_sys.html#testing-the-tof-time-of-flight-sensor)" section of your document. The text mentions installing the VL53L1X library in the Arduino IDE and running a sketch named proximity_detection.ino. However, the provided link https://github.com/Mjrovai/Arduino_Nicla_Vision/blob/main/Micropython/distance_image_meter.py leads to a MicroPython program distance_image_meter.py intended for use with the OpenMV camera. The linked program does not match the description in the document, which specifically refers to an Arduino sketch named proximity_detection.ino. I searched for proximity_detection.ino on GitHub but could not find any relevant results. Could you please review this section and update the link to point to the correct Arduino sketch that demonstrates the usage of the VL53L1X sensor with the Arduino IDE? If the mentioned proximity_detection.ino sketch is not available, it would be helpful to provide a suitable alternative or update the document text to match the linked program. Thank you for your attention to this matter and for providing clarity to the readers of your document. Best regards, Leon Feng
GiteaMirror added the area: book label 2026-03-22 15:24:37 -05:00
GiteaMirror commented 2026-03-22 15:24:39 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Mar 10, 2024):

Thank you @mouseart for the feedback! Really appreciate it. @Mjrovai can you please take a look at this?

@profvjreddi commented on GitHub (Mar 10, 2024): Thank you @mouseart for the feedback! Really appreciate it. @Mjrovai can you please take a look at this?
GiteaMirror commented 2026-03-22 15:24:40 -05:00
Author
Owner
Copy Link

@Mjrovai commented on GitHub (Mar 11, 2024):

Thank you, Leon (@mouseart).
The correct link for using the sensor with Arduino IDE is:
https://github.com/Mjrovai/Arduino_Nicla_Vision/blob/main/Arduino-IDE/proximity_detection/proximity_detection.ino

I will update the text properly.
Thanks
Marcelo

@Mjrovai commented on GitHub (Mar 11, 2024): Thank you, Leon (@mouseart). The correct link for using the sensor with Arduino IDE is: https://github.com/Mjrovai/Arduino_Nicla_Vision/blob/main/Arduino-IDE/proximity_detection/proximity_detection.ino I will update the text properly. Thanks Marcelo
GiteaMirror commented 2026-03-22 15:24:41 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Mar 13, 2024):

Thank you @Mjrovai for your fix here: 43d959c0f7

@profvjreddi commented on GitHub (Mar 13, 2024): Thank you @Mjrovai for your fix here: 43d959c0f7a8d8cd3ddaacbb24882509f39dec98
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label area: book
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#76
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?