[PR #1340] [MERGED] fix(tests): drop stray gradient test file from #1338 #7286

New Issue

GiteaMirror · 2026-04-24T17:23:28-05:00

GiteaMirror commented

2026-04-24 17:23:28 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1340
Author: @profvjreddi
Created: 4/16/2026
Status: ✅ Merged
Merged: 4/16/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/drop-stray-gradient-test

📝 Commits (1)

df40f69 fix(tests): drop stray gradient test file from #1338

📊 Changes

1 file changed (+0 additions, -392 deletions)

View changed files

➖ tinytorch/tests/06_autograd/test_gradient_correctness.py (+0 -392)

📄 Description

followup cleanup to #1338.

the merged PR contained an intended tokenization fix (5 lines) plus a stray copy of tinytorch/tests/06_autograd/test_gradient_correctness.py (392 lines) that was already the subject of #1336. the stray file has 17 failing tests which turned dev CI red.

this PR removes just the stray file. #1336 remains open as the proper home for those gradient correctness tests once they are green.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1340 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/16/2026 **Status:** ✅ Merged **Merged:** 4/16/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/drop-stray-gradient-test` --- ### 📝 Commits (1) - [`df40f69`](https://github.com/harvard-edge/cs249r_book/commit/df40f696aa0e023024f2d760f0777148d67adf14) fix(tests): drop stray gradient test file from #1338 ### 📊 Changes **1 file changed** (+0 additions, -392 deletions) <details> <summary>View changed files</summary> ➖ `tinytorch/tests/06_autograd/test_gradient_correctness.py` (+0 -392) </details> ### 📄 Description followup cleanup to #1338. the merged PR contained an intended tokenization fix (5 lines) plus a stray copy of tinytorch/tests/06_autograd/test_gradient_correctness.py (392 lines) that was already the subject of #1336. the stray file has 17 failing tests which turned dev CI red. this PR removes just the stray file. #1336 remains open as the proper home for those gradient correctness tests once they are green. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-24 17:23:29 -05:00

GiteaMirror closed this issue

2026-04-24 17:23:29 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#7286