github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-07 02:03:55 -05:00
Code Issues 85 Packages Projects Releases 24 Wiki Activity

[PR #1229] [CLOSED] Fix incorrect P(deny) value in SHAP example #6402

New Issue
Closed
opened 2026-04-21 22:18:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 22:18:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1229
Author: @GronuJ
Created: 3/11/2026
Status: ❌ Closed

Base: dev ← Head: iss1228-fix-shap-pdeny-value

📝 Commits (1)

  • b689c3b Fix incorrect P(deny) value in SHAP example (issue #1228)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 book/quarto/contents/vol2/responsible_ai/responsible_ai.qmd (+2 -2)

📄 Description

Fixes #1228

The SHAP example in Chapter 17.5 (Responsible AI) computes:

P(approve) = 0.50 - 0.05 - 0.25 - 0.12 = 0.08

Therefore P(deny) = 1 - 0.08 = 0.92, not 0.72 as previously stated. This PR corrects both occurrences of the incorrect value.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1229 **Author:** [@GronuJ](https://github.com/GronuJ) **Created:** 3/11/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `iss1228-fix-shap-pdeny-value` --- ### 📝 Commits (1) - [`b689c3b`](https://github.com/harvard-edge/cs249r_book/commit/b689c3bada7051da5bd9b74afc50c71af720e11c) Fix incorrect P(deny) value in SHAP example (issue #1228) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `book/quarto/contents/vol2/responsible_ai/responsible_ai.qmd` (+2 -2) </details> ### 📄 Description Fixes #1228 The SHAP example in Chapter 17.5 (Responsible AI) computes: P(approve) = 0.50 - 0.05 - 0.25 - 0.12 = 0.08 Therefore P(deny) = 1 - 0.08 = **0.92**, not 0.72 as previously stated. This PR corrects both occurrences of the incorrect value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 22:18:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#6402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?