[PR #1373] [MERGED] fix(ci): unblock book-validate by grandfathering 29 bib violations #5155

New Issue

GiteaMirror · 2026-04-19T12:50:40-05:00

GiteaMirror commented

2026-04-19 12:50:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1373
Author: @profvjreddi
Created: 4/17/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/book-validate-bib

📝 Commits (1)

3757e99 chore(bib): grandfather 29 missing-publisher @inproceedings entries

📊 Changes

1 file changed (+180 additions, -0 deletions)

View changed files

📝 book/tools/bib_lint_baseline.json (+180 -0)

📄 Description

Summary

book-validate-dev.yml has been failing on every dev push since 2026-04-13 (run 24346051021) because the bib-lint pre-commit hook reports 29 NEW violations beyond the baseline — all the same rule:

@inproceedings missing required field publisher

These entries are in paper-companion bibs that were added/extended over recent merges:

periodic-table/paper/references.bib — 20 entries
interviews/paper/references.bib — 9 entries

Both files already have grandfathered entries for the exact same rule (33 and 5 respectively), so extending the baseline is consistent with the established pattern for paper-companion bibs. The pre-commit config comment explicitly sanctions this:

Regenerate baseline via: python3 book/tools/bib_lint.py --all --baseline (do this only when intentionally accepting new violations after a sweep closes).

What changed

book/tools/bib_lint_baseline.json — +180 lines (29 additive entries, all missing-required-field / publisher). No .bib files modified.

Verification

$ python3 book/tools/bib_lint.py --check --all
bib_lint: check mode, 19 file(s)
Total: 0 NEW errors (67 grandfathered), 81 warnings
exit=0

$ pre-commit run bib-lint --all-files
Repo: Validate bibtex against §5 (semantic)..............................Passed

Follow-up (not this PR)

If the project decides it wants actual publisher values on these entries rather than grandfathered-silence, that's a separate bib metadata sweep (lookup + add publisher = {...} per conference). Out of scope here — this PR only restores the green badge.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1373 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/17/2026 **Status:** ✅ Merged **Merged:** 4/17/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/book-validate-bib` --- ### 📝 Commits (1) - [`3757e99`](https://github.com/harvard-edge/cs249r_book/commit/3757e9909e7c8d6f4f42623314efccefb3989b82) chore(bib): grandfather 29 missing-publisher @inproceedings entries ### 📊 Changes **1 file changed** (+180 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `book/tools/bib_lint_baseline.json` (+180 -0) </details> ### 📄 Description ## Summary `book-validate-dev.yml` has been failing on every `dev` push since 2026-04-13 (run 24346051021) because the `bib-lint` pre-commit hook reports 29 **NEW** violations beyond the baseline — all the same rule: > `@inproceedings` missing required field `publisher` These entries are in paper-companion bibs that were added/extended over recent merges: - `periodic-table/paper/references.bib` — 20 entries - `interviews/paper/references.bib` — 9 entries Both files already have grandfathered entries for the exact same rule (33 and 5 respectively), so extending the baseline is consistent with the established pattern for paper-companion bibs. The pre-commit config comment explicitly sanctions this: > Regenerate baseline via: `python3 book/tools/bib_lint.py --all --baseline` (do this only when intentionally accepting new violations after a sweep closes). ## What changed - `book/tools/bib_lint_baseline.json` — +180 lines (29 additive entries, all `missing-required-field` / `publisher`). No `.bib` files modified. ## Verification ``` $ python3 book/tools/bib_lint.py --check --all bib_lint: check mode, 19 file(s) Total: 0 NEW errors (67 grandfathered), 81 warnings exit=0 $ pre-commit run bib-lint --all-files Repo: Validate bibtex against §5 (semantic)..............................Passed ``` ## Follow-up (not this PR) If the project decides it wants actual publisher values on these entries rather than grandfathered-silence, that's a separate bib metadata sweep (lookup + add `publisher = {...}` per conference). Out of scope here — this PR only restores the green badge. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-19 12:50:40 -05:00

GiteaMirror closed this issue

2026-04-19 12:50:41 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#5155