github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-22 05:53:13 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1271] [MERGED] Fix #1268 installscript fails on ubuntu LTS 20.04 #5087

New Issue
Closed
opened 2026-04-19 12:48:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 12:48:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1271
Author: @asgalon
Created: 3/22/2026
Status: ✅ Merged
Merged: 3/22/2026
Merged by: @profvjreddi

Base: dev ← Head: feature/feature-1268

📝 Commits (4)

  • e81e72c Fix #1268 installscript fails on ubuntu LTS 20.04
  • fefdfb2 Fix #1268 installscript fails on ubuntu LTS 20.04
  • 3b1e11a Merge remote-tracking branch 'origin/feature/feature-1268' into feature/feature-1268
  • b9d8c4c Fix #1268 replaced 3.8+ by 3.9+ in output and commets

📊 Changes

1 file changed (+35 additions, -11 deletions)

View changed files

📝 tinytorch/site/extra/install.sh (+35 -11)

📄 Description

See discussion #1087

Made the following changes:

  • removed python3.8 support because of dependency problems. It apparently no longer works without complicating requirements.txt, and probably not even then.
  • checking for git > 2.25.1 to avoid --sparse command line args bug.

The problem should affect only very ancient distributions, but since it happened only three months ago it probably will happen again. From my experience, many people have difficulties upgrading their linux distribution after a couple of years. I have observed that they often just reinstall the system from scratch and avoid that for data loss issues.

I have tested the install script with ubuntu 20.04 installed in a docker container and on a current Mac Book Pro with the following results:

ubuntu 20.04:

tinytorch@d8f93717750f:~/projects$ ./install.sh

  Tiny?Torch v0.1.9
  Don't import it. Build it.

Checking prerequisites...
? git version > 2.25.1 required. If you are using ubuntu LTS 20.04, please upgrade to ubuntu LTS 22.04 or clone project and extract tinytorch subdirectory manually.
? Found Python 3.8, but 3.9+ is required
  Install: https://python.org/downloads or 'brew install python' or 'apt install python3.9' or python 3.12

? Missing prerequisites. Please fix the issues above.

The "?" show up because of restricted terminal support in the docker container terminal output, nothing to do with the changes.

OSX 26.3.1:

La-Bestia:~/projects/test[1016]> /Users/peter/PycharmProjects/cs249r_book/tinytorch/site/extra/install.sh

  Tiny🔥Torch v0.1.9
  Don't import it. Build it.

Checking prerequisites...
✓ Git 2.50.1
✓ Python 3.13 (python3.13)
✓ Python venv module
✓ GitHub reachable

Where would you like to install Tiny🔥Torch?
  Press Enter for default: /Users/peter/projects/test/tinytorch

Install directory [tinytorch]: 

This will create a tinytorch folder here:
  /Users/peter/projects/test/tinytorch

What will be installed:
  - Tiny🔥Torch learning modules
  - Python virtual environment (.venv/)
  - tito CLI tool

Source: harvard-edge/cs249r_book (main branch)

Continue? [Y/n] 

[1/4] Downloading from GitHub...
✓ Downloaded TinyTorch (f00520c)                        
[2/4] Creating Python environment...
✓ Created virtual environment using python3.13
[3/4] Installing dependencies...
✓ Installed dependencies                                
[4/4] Verifying installation...
✓ Verified tito CLI

✓ Tiny🔥Torch installed successfully!

Next steps:

  cd /Users/peter/projects/test/tinytorch
  source .venv/bin/activate
  tito setup

Then start building:

  tito module start 01

Documentation: https://tinytorch.ai

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1271 **Author:** [@asgalon](https://github.com/asgalon) **Created:** 3/22/2026 **Status:** ✅ Merged **Merged:** 3/22/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `feature/feature-1268` --- ### 📝 Commits (4) - [`e81e72c`](https://github.com/harvard-edge/cs249r_book/commit/e81e72c5006d4705fae724c1b62aaf6b9396a422) Fix #1268 installscript fails on ubuntu LTS 20.04 - [`fefdfb2`](https://github.com/harvard-edge/cs249r_book/commit/fefdfb201946054ee20a34cbfa4056126de59a58) Fix #1268 installscript fails on ubuntu LTS 20.04 - [`3b1e11a`](https://github.com/harvard-edge/cs249r_book/commit/3b1e11a636018694202dd8ebd05325f47b26d0e6) Merge remote-tracking branch 'origin/feature/feature-1268' into feature/feature-1268 - [`b9d8c4c`](https://github.com/harvard-edge/cs249r_book/commit/b9d8c4c58e59c06dcfb05503bd7a179078982c96) Fix #1268 replaced 3.8+ by 3.9+ in output and commets ### 📊 Changes **1 file changed** (+35 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/site/extra/install.sh` (+35 -11) </details> ### 📄 Description See discussion #1087 Made the following changes: - removed python3.8 support because of dependency problems. It apparently no longer works without complicating requirements.txt, and probably not even then. - checking for git > 2.25.1 to avoid --sparse command line args bug. The problem should affect only very ancient distributions, but since it happened only three months ago it probably will happen again. From my experience, many people have difficulties upgrading their linux distribution after a couple of years. I have observed that they often just reinstall the system from scratch and avoid that for data loss issues. I have tested the install script with ubuntu 20.04 installed in a docker container and on a current Mac Book Pro with the following results: ubuntu 20.04: ``` tinytorch@d8f93717750f:~/projects$ ./install.sh Tiny?Torch v0.1.9 Don't import it. Build it. Checking prerequisites... ? git version > 2.25.1 required. If you are using ubuntu LTS 20.04, please upgrade to ubuntu LTS 22.04 or clone project and extract tinytorch subdirectory manually. ? Found Python 3.8, but 3.9+ is required Install: https://python.org/downloads or 'brew install python' or 'apt install python3.9' or python 3.12 ? Missing prerequisites. Please fix the issues above. ``` The "?" show up because of restricted terminal support in the docker container terminal output, nothing to do with the changes. OSX 26.3.1: ``` La-Bestia:~/projects/test[1016]> /Users/peter/PycharmProjects/cs249r_book/tinytorch/site/extra/install.sh Tiny🔥Torch v0.1.9 Don't import it. Build it. Checking prerequisites... ✓ Git 2.50.1 ✓ Python 3.13 (python3.13) ✓ Python venv module ✓ GitHub reachable Where would you like to install Tiny🔥Torch? Press Enter for default: /Users/peter/projects/test/tinytorch Install directory [tinytorch]: This will create a tinytorch folder here: /Users/peter/projects/test/tinytorch What will be installed: - Tiny🔥Torch learning modules - Python virtual environment (.venv/) - tito CLI tool Source: harvard-edge/cs249r_book (main branch) Continue? [Y/n] [1/4] Downloading from GitHub... ✓ Downloaded TinyTorch (f00520c) [2/4] Creating Python environment... ✓ Created virtual environment using python3.13 [3/4] Installing dependencies... ✓ Installed dependencies [4/4] Verifying installation... ✓ Verified tito CLI ✓ Tiny🔥Torch installed successfully! Next steps: cd /Users/peter/projects/test/tinytorch source .venv/bin/activate tito setup Then start building: tito module start 01 Documentation: https://tinytorch.ai ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 12:48:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#5087
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?