github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-21 00:23:30 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1741] [MERGED] Fix MLSysim landing page dark mode code and references #36379

New Issue
Closed
opened 2026-07-16 00:14:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-16 00:14:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1741
Author: @farhan523
Created: 5/13/2026
Status: ✅ Merged
Merged: 5/14/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mlsysim-root-dark-mode-references

📝 Commits (1)

  • 6488a93 Fix MLSysim landing page dark mode references

📊 Changes

1 file changed (+85 additions, -0 deletions)

View changed files

📝 mlsysim/docs/styles/landing.css (+85 -0)

📄 Description

Summary

  • fix dark-mode styling for code blocks on the MLSysim landing page
  • fix dark-mode styling for the root-page bibliography appendix and reference links
  • keep the local mlsysim/docs/_quarto.yml preview workaround out of this PR

Before:
Screenshot 2026-05-13 164314

Screenshot 2026-05-13 164326 Screenshot 2026-05-13 164333

After:

Screenshot 2026-05-13 164349 Screenshot 2026-05-13 164402 Screenshot 2026-05-13 164414

Testing

  • verified the MLSysim Quarto preview responds locally on http://127.0.0.1:4210/
  • confirmed the dark-mode CSS is served by the live preview
  • confirmed the commit only includes mlsysim/docs/styles/landing.css

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1741 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/13/2026 **Status:** ✅ Merged **Merged:** 5/14/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mlsysim-root-dark-mode-references` --- ### 📝 Commits (1) - [`6488a93`](https://github.com/harvard-edge/cs249r_book/commit/6488a9383d54c8ab48e1d396e20c40dd6d9f9c20) Fix MLSysim landing page dark mode references ### 📊 Changes **1 file changed** (+85 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/docs/styles/landing.css` (+85 -0) </details> ### 📄 Description ## Summary - fix dark-mode styling for code blocks on the MLSysim landing page - fix dark-mode styling for the root-page bibliography appendix and reference links - keep the local mlsysim/docs/_quarto.yml preview workaround out of this PR Before: <img width="842" height="516" alt="Screenshot 2026-05-13 164314" src="https://github.com/user-attachments/assets/2e8f0c0c-3199-48bb-8bd4-4d3f72a8773d" /> <img width="821" height="392" alt="Screenshot 2026-05-13 164326" src="https://github.com/user-attachments/assets/e2b12e17-08d7-4e74-bbf2-3022b182714f" /> <img width="1436" height="146" alt="Screenshot 2026-05-13 164333" src="https://github.com/user-attachments/assets/e6ebd6b6-b125-4459-8c81-f681c5d3687e" /> **After:** <img width="1080" height="629" alt="Screenshot 2026-05-13 164349" src="https://github.com/user-attachments/assets/fc25981e-f6a3-4cbf-b1b8-c72597dc06a6" /> <img width="1039" height="476" alt="Screenshot 2026-05-13 164402" src="https://github.com/user-attachments/assets/0e717eb7-9aa4-45d1-83b5-d2d308384b85" /> <img width="1901" height="204" alt="Screenshot 2026-05-13 164414" src="https://github.com/user-attachments/assets/d9902305-83a1-4092-a85f-e7a96d43e39a" /> ## Testing - verified the MLSysim Quarto preview responds locally on http://127.0.0.1:4210/ - confirmed the dark-mode CSS is served by the live preview - confirmed the commit only includes mlsysim/docs/styles/landing.css --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-16 00:14:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#36379