[PR #1690] [MERGED] docs(tinytorch): add GELU implementation and explanation #36331

Closed
opened 2026-07-16 00:09:21 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1690
Author: @bdub-1
Created: 5/6/2026
Status: Merged
Merged: 5/10/2026
Merged by: @profvjreddi

Base: devHead: bdub-1-feat/tinytorch-module02-gelu-impl


📝 Commits (4)

  • 415056e Document GELU activation function in 02_activations.qmd
  • 2526cf6 docs(tinytorch): add GELU implementation
  • 0f12bb8 Update GELU code to reflect src code change
  • 55b7cca docs(tinytorch): polish GELU activation section

📊 Changes

1 file changed (+20 additions, -1 deletions)

View changed files

📝 tinytorch/quarto/modules/02_activations.qmd (+20 -1)

📄 Description

Problem

Closes #1689

The "Activations" module (Module 02) mentioned the GELU activation function is referenced throughout the docs and is required in the coding module, but the actual implementation and explanation were missing from the core content.

Fix

  • Added the GELU class implementation to 02_activations.qmd
  • Documented the computational tradeoff (4–5x cost vs ReLU)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1690 **Author:** [@bdub-1](https://github.com/bdub-1) **Created:** 5/6/2026 **Status:** ✅ Merged **Merged:** 5/10/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `bdub-1-feat/tinytorch-module02-gelu-impl` --- ### 📝 Commits (4) - [`415056e`](https://github.com/harvard-edge/cs249r_book/commit/415056e365084ca6f113c7c375ebd8b9c0ac18e8) Document GELU activation function in 02_activations.qmd - [`2526cf6`](https://github.com/harvard-edge/cs249r_book/commit/2526cf6aaadaae72365471ab655ce4ace5852bed) docs(tinytorch): add GELU implementation - [`0f12bb8`](https://github.com/harvard-edge/cs249r_book/commit/0f12bb82292a3926943585f43be3dfb68a674f7d) Update GELU code to reflect src code change - [`55b7cca`](https://github.com/harvard-edge/cs249r_book/commit/55b7cca2540c8ae8edbc098c4cfa5de5442c5e26) docs(tinytorch): polish GELU activation section ### 📊 Changes **1 file changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/quarto/modules/02_activations.qmd` (+20 -1) </details> ### 📄 Description ## Problem Closes #1689 The "Activations" module (Module 02) mentioned the GELU activation function is referenced throughout the docs and is required in the coding module, but the actual implementation and explanation were missing from the core content. ## Fix - Added the `GELU` class implementation to `02_activations.qmd` - Documented the computational tradeoff (4–5x cost vs ReLU) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-16 00:09:22 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#36331