github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 16:34:48 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1640] [MERGED] fix(instructors): readable landing tables and footer CTA #36284

New Issue
Closed
opened 2026-07-16 00:04:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-16 00:04:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1640
Author: @farhan523
Created: 5/4/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/instructors-landing-readability

📝 Commits (1)

  • e1f66c6 fix(instructors): readable landing tables and footer CTA in dark mode

📊 Changes

1 file changed (+30 additions, -0 deletions)

View changed files

📝 instructors/assets/styles/dark-mode.scss (+30 -0)

📄 Description

Summary

  • .inv-table (Course Materials, Teaching Resources) hardcoded #1a1a2e / #4a5568 text and light hover background, making cells unreadable against the dark theme.
  • .footer-cta card hardcoded a light #f8fafc background, hiding the "Start teaching AI Systems" heading.
  • Added scoped overrides in instructors/assets/styles/dark-mode.scss for both, plus indigo accent for the last-column action links.

Before:
Screenshot 2026-05-04 084820

After:
Screenshot 2026-05-04 084810

Test plan

  • Open /instructors/ in dark mode — Course Materials and Teaching Resources tables are readable.
  • Hover row tints subtly (no flash to light).
  • Last-column links render in the indigo accent; inline body links keep crimson.
  • "Ready to Adopt?" card uses the elevated dark background; heading and copy are readable.
  • Light mode is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1640 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/4/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/instructors-landing-readability` --- ### 📝 Commits (1) - [`e1f66c6`](https://github.com/harvard-edge/cs249r_book/commit/e1f66c6d7719c03632041918343746c3f7be42f5) fix(instructors): readable landing tables and footer CTA in dark mode ### 📊 Changes **1 file changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `instructors/assets/styles/dark-mode.scss` (+30 -0) </details> ### 📄 Description ## Summary - `.inv-table` (Course Materials, Teaching Resources) hardcoded `#1a1a2e` / `#4a5568` text and light hover background, making cells unreadable against the dark theme. - `.footer-cta` card hardcoded a light `#f8fafc` background, hiding the "Start teaching AI Systems" heading. - Added scoped overrides in `instructors/assets/styles/dark-mode.scss` for both, plus indigo accent for the last-column action links. Before: <img width="664" height="691" alt="Screenshot 2026-05-04 084820" src="https://github.com/user-attachments/assets/17543dc6-6685-4ae6-8037-75f6c3f6e199" /> After: <img width="687" height="729" alt="Screenshot 2026-05-04 084810" src="https://github.com/user-attachments/assets/adbf8d7b-79ac-4c14-a72e-da4253676517" /> ## Test plan - [ ] Open `/instructors/` in dark mode — Course Materials and Teaching Resources tables are readable. - [ ] Hover row tints subtly (no flash to light). - [ ] Last-column links render in the indigo accent; inline body links keep crimson. - [ ] "Ready to Adopt?" card uses the elevated dark background; heading and copy are readable. - [ ] Light mode is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-16 00:04:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#36284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?