github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-19 01:14:07 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1638] [MERGED] fix(instructors): improve dark mode dropdown menu contrast #36282

New Issue
Closed
opened 2026-07-16 00:04:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-16 00:04:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1638
Author: @farhan523
Created: 5/3/2026
Status: ✅ Merged
Merged: 5/3/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/instructors-dark-mode-dropdown

📝 Commits (1)

  • 81faa71 fix(instructors): improve dark mode dropdown menu contrast

📊 Changes

1 file changed (+32 additions, -0 deletions)

View changed files

📝 instructors/assets/styles/dark-mode.scss (+32 -0)

📄 Description

Summary

  • Top-navbar dropdown submenus on the instructor site rendered with a white background in dark mode.
  • Add a dark-mode block in instructors/assets/styles/dark-mode.scss that sets dropdown surface/items/headers/dividers to the Blueprint dark palette with indigo hover/active state.

Before:
Screenshot 2026-05-03 194720

After:
Screenshot 2026-05-03 194728

Test plan

  • cd instructors && quarto preview
  • Toggle dark mode and open each top-nav dropdown — backgrounds match the dark navbar, items are readable, hover/active uses indigo.
  • Verify light mode is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1638 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/3/2026 **Status:** ✅ Merged **Merged:** 5/3/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/instructors-dark-mode-dropdown` --- ### 📝 Commits (1) - [`81faa71`](https://github.com/harvard-edge/cs249r_book/commit/81faa714508e886ce7cad436b0f5e9bdf56a2b15) fix(instructors): improve dark mode dropdown menu contrast ### 📊 Changes **1 file changed** (+32 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `instructors/assets/styles/dark-mode.scss` (+32 -0) </details> ### 📄 Description ## Summary - Top-navbar dropdown submenus on the instructor site rendered with a white background in dark mode. - Add a dark-mode block in `instructors/assets/styles/dark-mode.scss` that sets dropdown surface/items/headers/dividers to the Blueprint dark palette with indigo hover/active state. Before: <img width="351" height="224" alt="Screenshot 2026-05-03 194720" src="https://github.com/user-attachments/assets/ba610070-ef26-4cba-a33a-4d280fef68dd" /> After: <img width="451" height="294" alt="Screenshot 2026-05-03 194728" src="https://github.com/user-attachments/assets/97152ca0-a3eb-4ac7-8264-a37009199398" /> ## Test plan - [ ] `cd instructors && quarto preview` - [ ] Toggle dark mode and open each top-nav dropdown — backgrounds match the dark navbar, items are readable, hover/active uses indigo. - [ ] Verify light mode is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-16 00:04:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#36282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?