The Subscribe link in the StaffML EcosystemBar points at #subscribe on both desktop and mobile, but no element with id=\"subscribe\" exists anywhere in interviews/staffml/. Clicking it appends #subscribe to the URL and does nothing — silent dead-end.
The #subscribe anchor on the main Quarto site is presumably wired to a JS popover (subscribe modal) that opens when clicked. StaffML is a separate Next.js app and inherits the link target but not the popover wiring, so the link dangles.
Suggested fix
Point the StaffML Subscribe link at https://mlsysbook.ai/newsletter/ — that's already the canonical newsletter URL in both shared/config/footer-site.yml and the Connect → community → newsletter entry in shared/config/navbar-common.yml. One-line change in two places in EcosystemBar.tsx.
Alternative paths if the newsletter URL isn't right:
Port the popover JS to StaffML and add a real #subscribe section to the page that opens it.
Remove the link entirely until a real target exists.
Point at a different URL (mailto, external form, etc.).
What I'd like from you
A one-line answer: what's the right target? I'll send a PR with whatever you confirm. Thanks! @profvjreddi
Originally created by @farhan523 on GitHub (Jun 6, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1844
## Bug
The Subscribe link in the StaffML `EcosystemBar` points at `#subscribe` on both desktop and mobile, but no element with `id=\"subscribe\"` exists anywhere in `interviews/staffml/`. Clicking it appends `#subscribe` to the URL and does nothing — silent dead-end.
- Desktop link: [`interviews/staffml/src/components/EcosystemBar.tsx#L492`](https://github.com/harvard-edge/cs249r_book/blob/dev/interviews/staffml/src/components/EcosystemBar.tsx#L492)
- Mobile link: [`interviews/staffml/src/components/EcosystemBar.tsx#L620`](https://github.com/harvard-edge/cs249r_book/blob/dev/interviews/staffml/src/components/EcosystemBar.tsx#L620)
- `grep -r 'id=\"subscribe\"' interviews/staffml/src` → no matches
## Why this happened (best guess)
Commit [`8b1c235f26 fix(staffml): complete navbar parity with navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/commit/8b1c235f26) ported the navbar structure from [`shared/config/navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/navbar-common.yml). That YAML has BOTH:
```yaml
href: \"#subscribe\"
id: \"navbar-subscribe-btn\"
```
…and a separate Newsletter entry:
```yaml
href: https://mlsysbook.ai/newsletter/
```
The `#subscribe` anchor on the main Quarto site is presumably wired to a JS popover (subscribe modal) that opens when clicked. StaffML is a separate Next.js app and inherits the link target but not the popover wiring, so the link dangles.
## Suggested fix
Point the StaffML Subscribe link at `https://mlsysbook.ai/newsletter/` — that's already the canonical newsletter URL in both [`shared/config/footer-site.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/footer-site.yml) and the `Connect → community → newsletter` entry in [`shared/config/navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/navbar-common.yml). One-line change in two places in `EcosystemBar.tsx`.
**Alternative paths** if the newsletter URL isn't right:
- Port the popover JS to StaffML and add a real `#subscribe` section to the page that opens it.
- Remove the link entirely until a real target exists.
- Point at a different URL (mailto, external form, etc.).
## What I'd like from you
A one-line answer: **what's the right target?** I'll send a PR with whatever you confirm. Thanks! @profvjreddi
Thanks @farhan523, fixed. The EcosystemBar Subscribe link (desktop and mobile) was pointing at a non-existent #subscribe anchor; it now points to https://mlsysbook.ai/newsletter/, matching the shared navbar config, which also documents why an internal #subscribe anchor is avoided (Safari content blockers hide anchors whose href contains "subscribe"). It will go live with the next StaffML deploy.
@all-contributors please add @farhan523 for 🪲 Bug in StaffML
<!-- gh-comment-id:4868021046 -->
@profvjreddi commented on GitHub (Jul 2, 2026):
Thanks @farhan523, fixed. The EcosystemBar Subscribe link (desktop and mobile) was pointing at a non-existent `#subscribe` anchor; it now points to https://mlsysbook.ai/newsletter/, matching the shared navbar config, which also documents why an internal `#subscribe` anchor is avoided (Safari content blockers hide anchors whose href contains "subscribe"). It will go live with the next StaffML deploy.
@all-contributors please add @farhan523 for 🪲 Bug in StaffML
<!-- gh-comment-id:4868062600 -->
@github-actions[bot] commented on GitHub (Jul 2, 2026):
I've added @farhan523 as a contributor to **staffml**! :tada:
**Recognized for:** bug, code
**Project(s):** staffml (explicitly mentioned in comment)
**Based on:** @all-contributors please add @farhan523 for 🪲 Bug in StaffML
The contributor list has been updated in:
- `interviews/.all-contributorsrc`, `interviews/README.md`
- Main `README.md`
We love recognizing our contributors! :heart:
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @farhan523 on GitHub (Jun 6, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1844
Bug
The Subscribe link in the StaffML
EcosystemBarpoints at#subscribeon both desktop and mobile, but no element withid=\"subscribe\"exists anywhere ininterviews/staffml/. Clicking it appends#subscribeto the URL and does nothing — silent dead-end.interviews/staffml/src/components/EcosystemBar.tsx#L492interviews/staffml/src/components/EcosystemBar.tsx#L620grep -r 'id=\"subscribe\"' interviews/staffml/src→ no matchesWhy this happened (best guess)
Commit
8b1c235f26 fix(staffml): complete navbar parity with navbar-common.ymlported the navbar structure fromshared/config/navbar-common.yml. That YAML has BOTH:…and a separate Newsletter entry:
The
#subscribeanchor on the main Quarto site is presumably wired to a JS popover (subscribe modal) that opens when clicked. StaffML is a separate Next.js app and inherits the link target but not the popover wiring, so the link dangles.Suggested fix
Point the StaffML Subscribe link at
https://mlsysbook.ai/newsletter/— that's already the canonical newsletter URL in bothshared/config/footer-site.ymland theConnect → community → newsletterentry inshared/config/navbar-common.yml. One-line change in two places inEcosystemBar.tsx.Alternative paths if the newsletter URL isn't right:
#subscribesection to the page that opens it.What I'd like from you
A one-line answer: what's the right target? I'll send a PR with whatever you confirm. Thanks! @profvjreddi
@profvjreddi commented on GitHub (Jul 2, 2026):
Thanks @farhan523, fixed. The EcosystemBar Subscribe link (desktop and mobile) was pointing at a non-existent
#subscribeanchor; it now points to https://mlsysbook.ai/newsletter/, matching the shared navbar config, which also documents why an internal#subscribeanchor is avoided (Safari content blockers hide anchors whose href contains "subscribe"). It will go live with the next StaffML deploy.@all-contributors please add @farhan523 for 🪲 Bug in StaffML
@github-actions[bot] commented on GitHub (Jul 2, 2026):
I've added @farhan523 as a contributor to staffml! 🎉
Recognized for: bug, code
Project(s): staffml (explicitly mentioned in comment)
Based on: @all-contributors please add @farhan523 for 🪲 Bug in StaffML
The contributor list has been updated in:
interviews/.all-contributorsrc,interviews/README.mdREADME.mdWe love recognizing our contributors! ❤️