github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-15 21:28:33 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1932] [MERGED] fix(mlperf-edu): remove vacuous deterministic-seed check from quick_check_model #34656

New Issue
Closed
opened 2026-07-14 19:27:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-14 19:27:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1932
Author: @Shashank-Tripathi-07
Created: 7/7/2026
Status: ✅ Merged
Merged: 7/10/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/compliance-quick-check-vacuous-seed-check

📝 Commits (1)

  • 3949a87 fix(mlperf-edu): remove vacuous deterministic-seed check from quick_check_model

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 mlperf-edu/scripts/compliance_checker.py (+0 -1)

📄 Description

Summary

  • quick_check_model() only instantiates a fresh reference model to sanity-check parameter counts and dataset loading; no training run ever happens and no seed is read anywhere in this path.
  • check_deterministic_seed(result) was called with no seed argument, so it always compared the hardcoded default (42) against itself and passed unconditionally, regardless of whether a real run used any particular seed.
  • check_from_log() already performs this check correctly elsewhere by reading the real seed out of the training log (log.get("seed", -1)), so this call in quick_check_model() was pure dead weight that could only ever report a false PASS.

Test plan

  • Confirmed via code reading: check_deterministic_seed(seed: int = 42) compares seed == 42; the only other call site (check_from_log) passes the real seed, so removing the argument-less call in quick_check_model() does not affect any real seed verification.
  • grep confirms no remaining calls to check_deterministic_seed without an explicit seed argument.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1932 **Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07) **Created:** 7/7/2026 **Status:** ✅ Merged **Merged:** 7/10/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/compliance-quick-check-vacuous-seed-check` --- ### 📝 Commits (1) - [`3949a87`](https://github.com/harvard-edge/cs249r_book/commit/3949a871f70df9e630fe8b486d0a51a53a80ab4c) fix(mlperf-edu): remove vacuous deterministic-seed check from quick_check_model ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `mlperf-edu/scripts/compliance_checker.py` (+0 -1) </details> ### 📄 Description ## Summary - `quick_check_model()` only instantiates a fresh reference model to sanity-check parameter counts and dataset loading; no training run ever happens and no seed is read anywhere in this path. - `check_deterministic_seed(result)` was called with no `seed` argument, so it always compared the hardcoded default (`42`) against itself and passed unconditionally, regardless of whether a real run used any particular seed. - `check_from_log()` already performs this check correctly elsewhere by reading the real seed out of the training log (`log.get("seed", -1)`), so this call in `quick_check_model()` was pure dead weight that could only ever report a false PASS. ## Test plan - [x] Confirmed via code reading: `check_deterministic_seed(seed: int = 42)` compares `seed == 42`; the only other call site (`check_from_log`) passes the real seed, so removing the argument-less call in `quick_check_model()` does not affect any real seed verification. - [x] `grep` confirms no remaining calls to `check_deterministic_seed` without an explicit seed argument. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-14 19:27:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#34656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?