github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 00:44:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1819] [MERGED] fix(staffml): reset QuestionVisual failed state on visual.path change #34609

New Issue
Closed
opened 2026-07-14 19:22:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-14 19:22:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1819
Author: @farhan523
Created: 5/29/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/question-visual-reset-on-prop-change

📝 Commits (1)

  • c19d9fa fix(staffml): reset QuestionVisual failed state on visual.path change

📊 Changes

3 files changed (+58 additions, -0 deletions)

View changed files

➕ interviews/staffml/src/__tests__/question-visual.test.tsx (+45 -0)
📝 interviews/staffml/src/__tests__/setup.ts (+8 -0)
📝 interviews/staffml/src/components/QuestionVisual.tsx (+5 -0)

📄 Description

Summary

  • A question whose diagram failed to load left QuestionVisual in its error state across navigation. failed=true short-circuited before the next question's <img> could mount, so its onError could never reset things. Users saw "Diagram failed to load" on questions whose images were fine.
  • Fix uses the same useState + compare pattern as vault/TopicDetail.tsx, which React's docs recommend for resetting state when a prop changes.
  • Adds a regression test (renders, errors, re-renders with new path, asserts the error UI is cleared).
  • Adds a ResizeObserver stub in the vitest setup.ts so react-medium-image-zoom mounts cleanly under jsdom — without it the new test crashes.

Test plan

  • npx vitest run → 39/39 passing (was 37/37)
  • npx tsc --noEmit → clean
  • Manual verification: open /practice, block a diagram URL in DevTools → red error shows, navigate to next question → new diagram loads (instead of staying in error state)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1819 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/29/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/question-visual-reset-on-prop-change` --- ### 📝 Commits (1) - [`c19d9fa`](https://github.com/harvard-edge/cs249r_book/commit/c19d9faf5fc400f2b2df72bb13f3c2cbff1ea025) fix(staffml): reset QuestionVisual failed state on visual.path change ### 📊 Changes **3 files changed** (+58 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `interviews/staffml/src/__tests__/question-visual.test.tsx` (+45 -0) 📝 `interviews/staffml/src/__tests__/setup.ts` (+8 -0) 📝 `interviews/staffml/src/components/QuestionVisual.tsx` (+5 -0) </details> ### 📄 Description ## Summary - A question whose diagram failed to load left `QuestionVisual` in its error state across navigation. `failed=true` short-circuited before the next question's `<img>` could mount, so its `onError` could never reset things. Users saw "Diagram failed to load" on questions whose images were fine. - Fix uses the same `useState` + compare pattern as `vault/TopicDetail.tsx`, which React's docs recommend for resetting state when a prop changes. - Adds a regression test (renders, errors, re-renders with new path, asserts the error UI is cleared). - Adds a `ResizeObserver` stub in the vitest `setup.ts` so `react-medium-image-zoom` mounts cleanly under jsdom — without it the new test crashes. ## Test plan - [x] `npx vitest run` → 39/39 passing (was 37/37) - [x] `npx tsc --noEmit` → clean - [ ] Manual verification: open `/practice`, block a diagram URL in DevTools → red error shows, navigate to next question → new diagram loads (instead of staying in error state) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-14 19:22:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#34609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?