github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 08:28:07 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1593] [CLOSED] Fix staffml imports when only summary corpus is present #33178

New Issue
Closed
opened 2026-07-13 11:51:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-13 11:51:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1593
Author: @farhan523
Created: 4/28/2026
Status: ❌ Closed

Base: dev ← Head: fix/staffml-summary-corpus-imports

📝 Commits (1)

  • e07f246 Fix staffml summary corpus imports

📊 Changes

2 files changed (+13 additions, -4 deletions)

View changed files

📝 interviews/staffml/src/lib/corpus.ts (+12 -3)
📝 interviews/staffml/src/lib/taxonomy.ts (+1 -1)

📄 Description

## Summary
This fixes a local contributor/dev failure in `interviews/staffml` where some code still imports `src/data/corpus.json` even though this checkout only includes `src/data/corpus-summary.json`.

## What changed
- switch `src/lib/taxonomy.ts` to import `corpus-summary.json`
- make the static full-detail fallback in `src/lib/corpus.ts` stop hard-requiring the missing `corpus.json` artifact

## Problem solved
On a fresh checkout, running the staffml interview app can fail with:

```text
Module not found: Can't resolve '../data/corpus.json'

This PR aligns those imports with the summary-only bundle currently committed in the repo, so local dev can start without the legacy full-corpus JSON file.

Existing behavior impact

  • no change to summary metadata already provided by corpus-summary.json
  • local fallback paths no longer crash when corpus.json is absent
  • behavior remains consistent with the newer summary-plus-worker architecture already described in the code comments

Question

Should src/data/corpus.json still be treated as a required generated artifact for contributors, or is the summary-only flow now the intended default? If the former, I can follow up with a docs or generation-step fix instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1593 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 4/28/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/staffml-summary-corpus-imports` --- ### 📝 Commits (1) - [`e07f246`](https://github.com/harvard-edge/cs249r_book/commit/e07f246e2c2db45d151a4ed52043e55ad6150046) Fix staffml summary corpus imports ### 📊 Changes **2 files changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `interviews/staffml/src/lib/corpus.ts` (+12 -3) 📝 `interviews/staffml/src/lib/taxonomy.ts` (+1 -1) </details> ### 📄 Description ```md ## Summary This fixes a local contributor/dev failure in `interviews/staffml` where some code still imports `src/data/corpus.json` even though this checkout only includes `src/data/corpus-summary.json`. ## What changed - switch `src/lib/taxonomy.ts` to import `corpus-summary.json` - make the static full-detail fallback in `src/lib/corpus.ts` stop hard-requiring the missing `corpus.json` artifact ## Problem solved On a fresh checkout, running the staffml interview app can fail with: ```text Module not found: Can't resolve '../data/corpus.json' ``` This PR aligns those imports with the summary-only bundle currently committed in the repo, so local dev can start without the legacy full-corpus JSON file. ## Existing behavior impact - no change to summary metadata already provided by `corpus-summary.json` - local fallback paths no longer crash when `corpus.json` is absent - behavior remains consistent with the newer summary-plus-worker architecture already described in the code comments ## Question Should `src/data/corpus.json` still be treated as a required generated artifact for contributors, or is the summary-only flow now the intended default? If the former, I can follow up with a docs or generation-step fix instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-13 11:51:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#33178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?