[PR #1917] tinytorch module 09 diagrams and spacing #32186

Open
opened 2026-07-12 08:51:05 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1917
Author: @vedant-a-joshi
Created: 6/30/2026
Status: 🔄 Open

Base: devHead: tinytorch-module-09-fixes


📝 Commits (1)

  • 297fb7d tinytorch module 09 diagrams and spacing

📊 Changes

1 file changed (+141 additions, -194 deletions)

View changed files

📝 tinytorch/src/09_convolutions/09_convolutions.py (+141 -194)

📄 Description

TinyTorch Module 09

Fixed misaligned tables. Fixed calculations for some of the comparisons. Fixed formatting of cells with extra new lines at the top as well as HTML tags. Other minor fixes to make sure everything looks neat.

Tested by running pytest tests/, and the tests relevant to module 09 passed. Ran tito module test 09 and appropriate tests were passed. Note, there were some warnings about assert vs. return in the tests. Manually verified that formatting looks good by running it as a jupyter notebook and checking manually.

Revision of PR #1885


By submitting this PR, you agree to release your contribution under the project's license.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1917 **Author:** [@vedant-a-joshi](https://github.com/vedant-a-joshi) **Created:** 6/30/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `tinytorch-module-09-fixes` --- ### 📝 Commits (1) - [`297fb7d`](https://github.com/harvard-edge/cs249r_book/commit/297fb7dbf73180bb817986b93a857d8d02582f71) tinytorch module 09 diagrams and spacing ### 📊 Changes **1 file changed** (+141 additions, -194 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/09_convolutions/09_convolutions.py` (+141 -194) </details> ### 📄 Description ## TinyTorch Module 09 Fixed misaligned tables. Fixed calculations for some of the comparisons. Fixed formatting of cells with extra new lines at the top as well as HTML tags. Other minor fixes to make sure everything looks neat. Tested by running `pytest tests/`, and the tests relevant to module 09 passed. Ran `tito module test 09` and appropriate tests were passed. Note, there were some warnings about `assert` vs. `return` in the tests. Manually verified that formatting looks good by running it as a jupyter notebook and checking manually. Revision of PR #1885 --- *By submitting this PR, you agree to release your contribution under the project's license.* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-12 08:51:05 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#32186