github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 08:54:25 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1907] [CLOSED] fix(staffml): track and clear toast auto-dismiss timers #32176

New Issue
Closed
opened 2026-07-12 08:50:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-12 08:50:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1907
Author: @farhan523
Created: 6/26/2026
Status: ❌ Closed

Base: dev ← Head: fix/staffml-toast-timer-leak

📝 Commits (1)

  • aa682c9 fix(staffml): track and clear toast auto-dismiss timers

📊 Changes

2 files changed (+101 additions, -4 deletions)

View changed files

➕ interviews/staffml/src/__tests__/toast-timer-cleanup.test.tsx (+77 -0)
📝 interviews/staffml/src/components/Toast.tsx (+24 -4)

📄 Description

Problem

Each toast schedules a 4s setTimeout to auto-dismiss itself, but the timer handle was discarded:

const show = useCallback((msg) => {
  const id = nextId++;
  setToasts(prev => [...prev, { ...msg, id }]);
  setTimeout(() => { setToasts(prev => prev.filter(t => t.id !== id)); }, 4000); // never cleared
}, []);

So the timer was never cleared. If ToastProvider unmounts within 4s of a toast (route teardown, fast-refresh, test cleanup) the timer still fires setToasts on a dead tree, and a manual dismiss leaves the timer running to a wasted no-op tick.

Fix

  • Track each toast's timer in a useRef<Map<id, timeout>>.
  • Cancel the timer in dismiss().
  • Clear all pending timers in a provider unmount cleanup.

No user-visible behavior change.

Test

Adds toast-timer-cleanup.test.tsx (fake timers) asserting the pending timer is cleared on unmount and on manual dismiss, and that flushing timers afterward doesn't throw.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1907 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 6/26/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/staffml-toast-timer-leak` --- ### 📝 Commits (1) - [`aa682c9`](https://github.com/harvard-edge/cs249r_book/commit/aa682c9363183dbf2b2e70cbba83f84a3ecc8f97) fix(staffml): track and clear toast auto-dismiss timers ### 📊 Changes **2 files changed** (+101 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `interviews/staffml/src/__tests__/toast-timer-cleanup.test.tsx` (+77 -0) 📝 `interviews/staffml/src/components/Toast.tsx` (+24 -4) </details> ### 📄 Description ## Problem Each toast schedules a 4s `setTimeout` to auto-dismiss itself, but the timer handle was discarded: ```js const show = useCallback((msg) => { const id = nextId++; setToasts(prev => [...prev, { ...msg, id }]); setTimeout(() => { setToasts(prev => prev.filter(t => t.id !== id)); }, 4000); // never cleared }, []); ``` So the timer was never cleared. If `ToastProvider` unmounts within 4s of a toast (route teardown, fast-refresh, test cleanup) the timer still fires `setToasts` on a dead tree, and a manual dismiss leaves the timer running to a wasted no-op tick. ## Fix - Track each toast's timer in a `useRef<Map<id, timeout>>`. - Cancel the timer in `dismiss()`. - Clear all pending timers in a provider unmount cleanup. No user-visible behavior change. ## Test Adds `toast-timer-cleanup.test.tsx` (fake timers) asserting the pending timer is cleared on unmount and on manual dismiss, and that flushing timers afterward doesn't throw. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-12 08:50:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#32176
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?