github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-16 14:42:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[GH-ISSUE #1614] [Bug] Milestone 3 does not get past 75% test accuracy over xor problem #29747

New Issue
Closed
opened 2026-06-21 19:29:13 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-06-21 19:29:13 -05:00
Owner
Copy Link

Originally created by @AndreaMattiaGaravagno on GitHub (Apr 30, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1614

Area

TinyTorch

Location

Milestone 3

Description

Milestone 3 does not get past 75% test accuracy over xor problem

Expected Behavior

Milestone 3 should get 100% test accuracy over the xor problem

Environment (TinyTorch bugs only)

Tiny🔥Torch v0.1.10
Python 3.12.3
/home/andre/tinytorch/.venv

Originally created by @AndreaMattiaGaravagno on GitHub (Apr 30, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1614 ### Area TinyTorch ### Location Milestone 3 ### Description Milestone 3 does not get past 75% test accuracy over xor problem ### Expected Behavior Milestone 3 should get 100% test accuracy over the xor problem ### Environment (TinyTorch bugs only) Tiny🔥Torch v0.1.10 Python 3.12.3 /home/andre/tinytorch/.venv
GiteaMirror added the priority-hightype: bugarea: tinytorch labels 2026-06-21 19:29:14 -05:00
GiteaMirror commented 2026-06-21 19:29:18 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Apr 30, 2026):

Fixed in #1618 (merged to dev as f1d5a755f). Regression traced to commit d30257577c which migrated np.random.seed(1986) (global, affecting layer init) to a local rng = np.random.default_rng(7) that's never used — so layer weights ended up using tinytorch.core.layers.rng at the default seed=7, which on this XOR architecture lands in a dead-ReLU saddle (the 75% failure mode). Fix: explicitly re-seed tinytorch.core.layers.rng to 1986 right before model construction in 02_xor_solved.py. Verified 100% convergence (loss 0.0053 in 500 epochs).

<!-- gh-comment-id:4356774000 --> @profvjreddi commented on GitHub (Apr 30, 2026): Fixed in #1618 (merged to dev as f1d5a755f). Regression traced to commit d30257577c which migrated `np.random.seed(1986)` (global, affecting layer init) to a local `rng = np.random.default_rng(7)` that's never used — so layer weights ended up using `tinytorch.core.layers.rng` at the default seed=7, which on this XOR architecture lands in a dead-ReLU saddle (the 75% failure mode). Fix: explicitly re-seed `tinytorch.core.layers.rng` to 1986 right before model construction in `02_xor_solved.py`. Verified 100% convergence (loss 0.0053 in 500 epochs).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label area: tinytorch priority-high type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#29747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?