github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 16:34:48 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1884] [MERGED] ci(staffml): re-run preview-dev on vault-cli changes so the badge can't stale #29162

New Issue
Closed
opened 2026-06-20 13:04:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-20 13:04:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1884
Author: @profvjreddi
Created: 6/17/2026
Status: ✅ Merged
Merged: 6/17/2026
Merged by: @profvjreddi

Base: dev ← Head: chore/staffml-ci-path

📝 Commits (1)

  • b4f74be ci(staffml): re-run preview-dev on vault-cli changes so the badge can't stale

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 .github/workflows/staffml-preview-dev.yml (+6 -0)

📄 Description

Why

The README StaffML badge tracks staffml-preview-dev (push, dev). Its path filter triggers on interviews/staffml/**, interviews/vault/**, and the staffml workflow files — but not interviews/vault-cli/**, even though the badge-driving job lints vault-cli via the validate-vault workflow it calls.

So when #1879 sorted vault-cli imports (ruff I001), validate-vault went green but preview-dev never re-ran — leaving the badge stuck red on the earlier failing run.

Change

Add interviews/vault-cli/** to the preview-dev path filter so a vault-cli fix re-runs the badge-driving workflow. Editing the workflow file is itself a trigger path, so merging this re-runs preview-dev on the already-fixed dev and clears the badge.

CI-config only; no app/book changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1884 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 6/17/2026 **Status:** ✅ Merged **Merged:** 6/17/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `chore/staffml-ci-path` --- ### 📝 Commits (1) - [`b4f74be`](https://github.com/harvard-edge/cs249r_book/commit/b4f74be4748442eaccae3813a9e7a2e6d30ebef1) ci(staffml): re-run preview-dev on vault-cli changes so the badge can't stale ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/staffml-preview-dev.yml` (+6 -0) </details> ### 📄 Description ## Why The README **StaffML** badge tracks `staffml-preview-dev` (push, dev). Its path filter triggers on `interviews/staffml/**`, `interviews/vault/**`, and the staffml workflow files — but **not** `interviews/vault-cli/**`, even though the badge-driving job lints vault-cli via the `validate-vault` workflow it calls. So when #1879 sorted vault-cli imports (ruff I001), `validate-vault` went green but `preview-dev` never re-ran — leaving the badge stuck red on the earlier failing run. ## Change Add `interviews/vault-cli/**` to the preview-dev path filter so a vault-cli fix re-runs the badge-driving workflow. Editing the workflow file is itself a trigger path, so merging this re-runs preview-dev on the already-fixed dev and clears the badge. CI-config only; no app/book changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-20 13:04:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#29162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?