Feedback on Chapter 4 (DNN Architectures) #284

New Issue

GiteaMirror · 2026-03-22T15:35:15-05:00

GiteaMirror commented

2026-03-22 15:35:15 -05:00

Originally created by @zishenwan on GitHub (Jan 4, 2025).

Originally assigned to: @profvjreddi on GitHub.

Some brief comments on Chapter 4 (DNN Architectures):

Visual plots: I feel adding more visual plots would be helpful, e.g., add a RNN structure plot in Sec.4.4.2; add a attention structure plot in Sec.4.5.2; add a Transformer structure plot in Sec.4.6.4. Some visualization tool links might also helpful (e.g., CNN visualization, Transformer visualization). Those visualization can give more intuitions alongside existing texts and equations
Sec.4.7:
- Introduce roofline model concept might be helpful here, as it integrates compute/memory/data movement factors to offer insights on system-level design
- Table.4.4: there's a cell missing in table (key challenges of sequential access), maybe can fill "access latency" (delays due to memory hierarchy or insufficient prefetching mechanisms)

Originally created by @zishenwan on GitHub (Jan 4, 2025). Originally assigned to: @profvjreddi on GitHub. Some brief comments on Chapter 4 (DNN Architectures): - **Visual plots**: I feel adding more visual plots would be helpful, e.g., add a RNN structure plot in Sec.4.4.2; add a attention structure plot in Sec.4.5.2; add a Transformer structure plot in Sec.4.6.4. Some visualization tool links might also helpful (e.g., [CNN visualization](https://poloclub.github.io/cnn-explainer/), [Transformer visualization](https://poloclub.github.io/transformer-explainer/)). Those visualization can give more intuitions alongside existing texts and equations - **Sec.4.7**: - Introduce roofline model concept might be helpful here, as it integrates compute/memory/data movement factors to offer insights on system-level design - Table.4.4: there's a cell missing in table (key challenges of sequential access), maybe can fill "access latency" (delays due to memory hierarchy or insufficient prefetching mechanisms)

GiteaMirror added the area: book type: improvement labels 2026-03-22 15:35:15 -05:00

GiteaMirror closed this issue

2026-03-22 15:35:16 -05:00

GiteaMirror commented

2026-03-22 15:35:17 -05:00

@profvjreddi commented on GitHub (Jan 5, 2025):

Thanks @zishenwan for the constructive feedback 🙏

Those visualization elements you linked in are great. I wasn't aware of them! Please do let me know if there are others.

@profvjreddi commented on GitHub (Jan 5, 2025): Thanks @zishenwan for the constructive feedback 🙏 Those visualization elements you linked in are great. I wasn't aware of them! Please do let me know if there are others.

GiteaMirror referenced this issue

2026-03-22 15:48:22 -05:00

[PR #284] [MERGED] Revert "Trim and update benchmarking.qmd" #680

GiteaMirror referenced this issue

2026-04-11 08:10:52 -05:00

[PR #284] [MERGED] Revert "Trim and update benchmarking.qmd" #1903

GiteaMirror referenced this issue

2026-04-13 13:11:48 -05:00

[PR #284] [MERGED] Revert "Trim and update benchmarking.qmd" #2625

GiteaMirror referenced this issue

2026-04-16 01:44:22 -05:00

[PR #284] [MERGED] Revert "Trim and update benchmarking.qmd" #3304