[GH-ISSUE #1844] staffml: Subscribe link in EcosystemBar points at a non-existent #subscribe anchor #27945

Open
opened 2026-06-20 11:57:39 -05:00 by GiteaMirror · 0 comments
Owner

Originally created by @farhan523 on GitHub (Jun 6, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1844

Bug

The Subscribe link in the StaffML EcosystemBar points at #subscribe on both desktop and mobile, but no element with id=\"subscribe\" exists anywhere in interviews/staffml/. Clicking it appends #subscribe to the URL and does nothing — silent dead-end.

Why this happened (best guess)

Commit 8b1c235f26 fix(staffml): complete navbar parity with navbar-common.yml ported the navbar structure from shared/config/navbar-common.yml. That YAML has BOTH:

href: \"#subscribe\"
id: \"navbar-subscribe-btn\"

…and a separate Newsletter entry:

href: https://mlsysbook.ai/newsletter/

The #subscribe anchor on the main Quarto site is presumably wired to a JS popover (subscribe modal) that opens when clicked. StaffML is a separate Next.js app and inherits the link target but not the popover wiring, so the link dangles.

Suggested fix

Point the StaffML Subscribe link at https://mlsysbook.ai/newsletter/ — that's already the canonical newsletter URL in both shared/config/footer-site.yml and the Connect → community → newsletter entry in shared/config/navbar-common.yml. One-line change in two places in EcosystemBar.tsx.

Alternative paths if the newsletter URL isn't right:

  • Port the popover JS to StaffML and add a real #subscribe section to the page that opens it.
  • Remove the link entirely until a real target exists.
  • Point at a different URL (mailto, external form, etc.).

What I'd like from you

A one-line answer: what's the right target? I'll send a PR with whatever you confirm. Thanks! @profvjreddi

Originally created by @farhan523 on GitHub (Jun 6, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1844 ## Bug The Subscribe link in the StaffML `EcosystemBar` points at `#subscribe` on both desktop and mobile, but no element with `id=\"subscribe\"` exists anywhere in `interviews/staffml/`. Clicking it appends `#subscribe` to the URL and does nothing — silent dead-end. - Desktop link: [`interviews/staffml/src/components/EcosystemBar.tsx#L492`](https://github.com/harvard-edge/cs249r_book/blob/dev/interviews/staffml/src/components/EcosystemBar.tsx#L492) - Mobile link: [`interviews/staffml/src/components/EcosystemBar.tsx#L620`](https://github.com/harvard-edge/cs249r_book/blob/dev/interviews/staffml/src/components/EcosystemBar.tsx#L620) - `grep -r 'id=\"subscribe\"' interviews/staffml/src` → no matches ## Why this happened (best guess) Commit [`8b1c235f26 fix(staffml): complete navbar parity with navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/commit/8b1c235f26) ported the navbar structure from [`shared/config/navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/navbar-common.yml). That YAML has BOTH: ```yaml href: \"#subscribe\" id: \"navbar-subscribe-btn\" ``` …and a separate Newsletter entry: ```yaml href: https://mlsysbook.ai/newsletter/ ``` The `#subscribe` anchor on the main Quarto site is presumably wired to a JS popover (subscribe modal) that opens when clicked. StaffML is a separate Next.js app and inherits the link target but not the popover wiring, so the link dangles. ## Suggested fix Point the StaffML Subscribe link at `https://mlsysbook.ai/newsletter/` — that's already the canonical newsletter URL in both [`shared/config/footer-site.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/footer-site.yml) and the `Connect → community → newsletter` entry in [`shared/config/navbar-common.yml`](https://github.com/harvard-edge/cs249r_book/blob/dev/shared/config/navbar-common.yml). One-line change in two places in `EcosystemBar.tsx`. **Alternative paths** if the newsletter URL isn't right: - Port the popover JS to StaffML and add a real `#subscribe` section to the page that opens it. - Remove the link entirely until a real target exists. - Point at a different URL (mailto, external form, etc.). ## What I'd like from you A one-line answer: **what's the right target?** I'll send a PR with whatever you confirm. Thanks! @profvjreddi
GiteaMirror added the area: websitetype: bug labels 2026-06-20 11:57:39 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#27945